Skip to content

Fix a typo in WSDL#findChildParameterObject#686

Merged
herom merged 1 commit into
vpulim:masterfrom
arthurschreiber:patch-2
Jul 20, 2015
Merged

Fix a typo in WSDL#findChildParameterObject#686
herom merged 1 commit into
vpulim:masterfrom
arthurschreiber:patch-2

Conversation

@arthurschreiber

Copy link
Copy Markdown
Contributor

I'm not quite sure what impact this typo had, but it's obviously wrong.

I stumbled over this when reviewing the code changes between 0.6.0 and 0.6.1.

@herom

herom commented Jul 20, 2015

Copy link
Copy Markdown
Contributor

Thanks a lot @arthurschreiber - this seems like it was really borked... it seems that we didn't really have a test for this scenario, as it's obviously wrong 😨

Because, if you try it in your console, you can see that:

var x = [1, 2, 3];
var isBorked =Array.isArray(x && x.length); // returns `false` because `x && x.length === 3` (!)

console.log('Check for `isArray` on `x`: ' + isBorked; // returns false

herom added a commit that referenced this pull request Jul 20, 2015
Fix untested (obviously wrong) check in WSDL#findChildParameterObject
@herom
herom merged commit 9134c6b into vpulim:master Jul 20, 2015
diarmaidm pushed a commit to diarmaidm/node-soap that referenced this pull request Feb 3, 2016
Fix untested (obviously wrong) check in WSDL#findChildParameterObject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants