Prevent sending Object prototype methods as XML#699
Merged
Conversation
Adds `Object.prototype.hasOwnProperty` check in `WSDL.prototype.objectToRpcXML` and `WSDL.prototype.objectToXML`. This prevents sending arbitrary Javascript has XML nodes.
Contributor
Author
|
I can't seem to reproduce this failure. Any help or advice as to how to proceed on this PR? |
Contributor
|
Thanks a lot for your time and effort @ClaudiaJ 👍 The error had something to do with timeouts over at TravisCI - this should be fixed by a restart. Nonetheless I'd ask you to add a test in order to get your PR merged (as stated in our Guidelines for Submitting a PR. Thanks 😃 |
jsdevel
added a commit
that referenced
this pull request
Oct 23, 2015
Prevent sending Object prototype methods as XML
Collaborator
|
Thanks @ClaudiaJ ! I restarted the tests and they passed. |
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
Prevent sending Object prototype methods as XML
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Object.prototype.hasOwnPropertycheck inWSDL.prototype.objectToRpcXMLandWSDL.prototype.objectToXML.This prevents sending arbitrary Javascript as XML nodes when working with Classes (
var clientArgs = new Order(ordNum, qty)).