Fix for wsdl retrieval with specified options.httpClient#714
Merged
Conversation
kevmegforest
force-pushed
the
custom-httpClient-wsdl-fix
branch
7 times, most recently
from
September 11, 2015 02:51
610496a to
be5251f
Compare
Author
|
I don't know how to make the test I wrote work for nodejs 0.8 or 0.10. Do you have some idea. Thank you |
kevmegforest
force-pushed
the
custom-httpClient-wsdl-fix
branch
3 times, most recently
from
September 11, 2015 22:04
6435c6a to
8472e6d
Compare
…ttpClient. Before this, the specified client was not used when fetching the wsdl file. This fix will force the wsdl to use the specified httpClient.
kevmegforest
force-pushed
the
custom-httpClient-wsdl-fix
branch
from
September 11, 2015 22:06
8472e6d to
0d6390b
Compare
Author
|
I've made all the tests. It works with all node version Thank you |
Author
|
@jsdevel , Is there something I would need to add or modify for you to merge this pull request? |
jsdevel
added a commit
that referenced
this pull request
Sep 16, 2015
Fix for wsdl retrieval with specified options.httpClient
Collaborator
|
Looks good. Thanks @kevmegforest ! |
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
…l-fix Fix for wsdl retrieval with specified options.httpClient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using soap.createClient with special options.httpClient, the specified client is not used when fetching the wsdl file. This fix will force the wsdl to use the specified httpClient.