Add missing type attribute for PasswordText in WSSecurity#754
Merged
jsdevel merged 1 commit intoNov 2, 2015
Merged
Conversation
|
+1 |
Collaborator
|
@wmcmurray is there any way this can be a breaking change for existing uses using |
Contributor
Author
|
@jsdevel according to this document (around line 169) the #PasswordText type is the default, so if the type attribute is not specified, it'll be considered of this type anyway so I don't think it's a breaking change... but I am not a SOAP expert ;) |
Collaborator
|
Awesome @wmcmurray ! Verified in the |
wmcmurray
force-pushed
the
wssecurity-passwordtext-type-attribute
branch
from
November 1, 2015 22:41
b156678 to
9e762ab
Compare
Contributor
Author
|
Cool ! Commits are now squashed :) |
jsdevel
added a commit
that referenced
this pull request
Nov 2, 2015
…ttribute Add missing type attribute for PasswordText in WSSecurity
Collaborator
|
Thanks @wmcmurray ! |
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
…type-attribute Add missing type attribute for PasswordText in WSSecurity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just encountered a SOAP API from a big client that required the password type to be set in any cases, even with the default "PasswordText" type so... voilà !
Thank you :)