Adding ability to use PFX files

[tomgco]

Instead of extending ClientSSLSecurity to handle keys, certs, etc plus pfx keys, I have instead opted to create a new class specifically to use pfx files.

[jsdevel]

I like this strategy. Can you add support for passwords? I feel that may need to be an optional 3rd param.

[tomgco]

I like this strategy. Can you add support for passwords? I feel that may need to be an optional 3rd param.

Sure thing

[tomgco]

Oops, failing for older versions of node, will fix

[tomgco]

Ok @jsdevel, I have added in passphrase support for you, tests are also now passing.

[jsdevel]

can you update this jsdoc?

[jsdevel]

Pretty close @tomgco ! Once the last minor comments are addressed we'll merge.

[tomgco]

Pretty close @tomgco ! Once the last minor comments are addressed we'll merge.

Thanks, just adding these changes now.

[tomgco]

Ok, @jsdevel should be all working now and up to scratch.

Want me to rebase my commits into one, or is it good as they are?

[herom]

Thanks a lot for your time and effort @tomgco 👍

Please rebase and squash your commits into a single one as stated in our Guidelines on Submitting a Pull Request in order to get your PR merged 😃

[tomgco]

We are all rebased and should be ready to go, thanks @herom and @jsdevel!

[herom]

Thanks a ton @tomgco - it's people like you who make this library so awesome 😃

[jsdevel]

Thanks a ton @tomgco - it's people like you who make this library so awesome 😃

+1

[herom]

@tomgco Actually tests are failing over at TravisCI because client-password.pfx has expired and therefore the test "ClientSSLSecurityPFX should be usable in a request" (see here) throws an error.

Since you introduced this valuable extension and provided the files for testing would it be possible for you to add a valid file so that the tests are passing? Thanks a lot 👍

[jsdevel]

@tomgco can you re-generate the pfx files with a really long expire time or upload the command you used to create them?

[jsdevel]

It would be nice if we scripted these with bash or something.

[tomgco]

@jsdevel Hi, sorry about this, I haven’t got the scripts on hand at the moment (on different machine) but should be able to upload a script and a new cert come the weekend.

It would be nice if we scripted these with bash or something.

Even better, I have a script on that other machine already in bash, will require openssl though - but thats a given 💃

[herom]

@tomgco 👍

@jsdevel should we restart all tests on currently open PRs and merge them since you've commented out the currently invalid test?

[jsdevel]

should be able to upload a script and a new cert come the weekend.

Thanks @tomgco! That would be great 😄

should we restart all tests on currently open PRs and merge them since you've commented out the currently invalid test?

I think we'll need to call for a rebase first, otherwise the restart will continue to fail with the test uncommented. But yes, we should notify other PR authors.