Provide original req to Service#769
Merged
Merged
Conversation
Collaborator
|
@evantahler can you squash down to one commit? |
note new option in readme test for req within Service spacing update test for ipv6
Contributor
Author
|
sure thing. Squashed. |
jsdevel
added a commit
that referenced
this pull request
Oct 31, 2015
Provide original `req` to Service
Collaborator
|
Thanks @evantahler! |
Contributor
Author
|
Cool. Any plans on a new release to NPM? |
Collaborator
|
|
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
Provide original `req` to Service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this great project!
Sometimes you may want the original
reqpassed to your service methods. In the simplest case, you might just want to log the requestor's IP address.This PR passes
reqto the service methods as a 4th optional param.