Skip to content

Fixed issue when an error was undefined: undefined #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
herom merged 1 commit into from
Nov 2, 2015
Merged

Fixed issue when an error was undefined: undefined #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/wsdl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1418,9 +1418,9 @@ WSDL.prototype.xmlToObject = function(xml) {
if (root.Envelope) {
var body = root.Envelope.Body;
if (body.Fault) {
var code = selectn('faultcode.$value', body.Fault);
var string = selectn('faultstring.$value', body.Fault);
var detail = selectn('detail.$value', body.Fault);
var code = selectn('faultcode.$value', body.Fault) || selectn('faultcode', body.Fault);
var string = selectn('faultstring.$value', body.Fault) || selectn('faultstring', body.Fault);
var detail = selectn('detail.$value', body.Fault) || selectn('detail.message', body.Fault);
var error = new Error(code + ': ' + string + (detail ? ': ' + detail : ''));
error.root = root;
throw error;
Expand Down
1 change: 1 addition & 0 deletions test/request-response-samples-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ function generateTest(name, methodName, wsdlPath, headerJSON, securityJSON, requ
client[methodName](requestJSON, function(err, json, body, soapHeader){
if(requestJSON){
if (err) {
assert.notEqual('undefined: undefined', err.message);
assert.deepEqual(err.root, responseJSON);
} else {
// assert.deepEqual(json, responseJSON);
Expand Down
2 changes: 2 additions & 0 deletions test/server-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ describe('SOAP Server', function() {
client.GetLastTradePrice({ tickerSymbol: 'SOAP Fault v1.2' }, function(err, response, body) {
assert.ok(err);
var fault = err.root.Envelope.Body.Fault;
assert.equal(err.message, fault.faultcode + ': ' + fault.faultstring);
assert.equal(fault.Code.Value, "soap:Sender");
assert.equal(fault.Reason.Text, "Processing Error");
// Verify namespace on elements set according to fault spec 1.2
Expand All @@ -309,6 +310,7 @@ describe('SOAP Server', function() {
client.GetLastTradePrice({ tickerSymbol: 'SOAP Fault v1.1' }, function(err, response, body) {
assert.ok(err);
var fault = err.root.Envelope.Body.Fault;
assert.equal(err.message, fault.faultcode + ': ' + fault.faultstring);
assert.equal(fault.faultcode, "soap:Client.BadArguments");
assert.equal(fault.faultstring, "Error while processing arguments");
// Verify namespace on elements set according to fault spec 1.1
Expand Down