Skip to content

Moved the member variables into pubic scope to make it easier to customization of behaviors #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertosfield merged 3 commits into from
Sep 30, 2025
+118 −115
Merged

Moved the member variables into pubic scope to make it easier to customization of behaviors #1584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5f6f8d
Moved the member variables into pubic scope to make it easier to cust…
robertosfield Sep 30, 2025
d87020e
Restored originally name
robertosfield Sep 30, 2025
93b35f6
Restored original naming
robertosfield Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions include/vsg/app/RecordTraversal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ namespace vsg
ref_ptr<RecordedCommandBuffers> recordedCommandBuffers;

/// get the current State object used to track state and projection/modelview matrices for the current subgraph being traversed
State* getState() { return _state; }
State* getState() { return state; }

/// get the current CommandBuffer for the current subgraph being traversed
CommandBuffer* getCommandBuffer();
Expand All @@ -108,10 +108,10 @@ namespace vsg
uint32_t deviceID() const;

void setFrameStamp(FrameStamp* fs);
FrameStamp* getFrameStamp() { return _frameStamp; }
FrameStamp* getFrameStamp() { return frameStamp; }

void setDatabasePager(DatabasePager* dp);
DatabasePager* getDatabasePager() { return _databasePager; }
DatabasePager* getDatabasePager() { return databasePager; }

void apply(const Object& object);

Expand Down Expand Up @@ -170,22 +170,23 @@ namespace vsg
// clear the bins to record a new frame.
void clearBins();


// list of pairs of modelview matrix & region of interest
std::vector<std::pair<dmat4, const RegionOfInterest*>> regionsOfInterest;

protected:
virtual ~RecordTraversal();

ref_ptr<FrameStamp> _frameStamp;
ref_ptr<State> _state;
ref_ptr<FrameStamp> frameStamp;
ref_ptr<State> state;

// used to handle loading of PagedLOD external children.
ref_ptr<DatabasePager> _databasePager;
ref_ptr<CulledPagedLODs> _culledPagedLODs;
ref_ptr<DatabasePager> databasePager;
ref_ptr<CulledPagedLODs> culledPagedLODs;

int32_t _minimumBinNumber = 0;
std::vector<ref_ptr<Bin>> _bins;
ref_ptr<ViewDependentState> _viewDependentState;
int32_t minimumBinNumber = 0;
std::vector<ref_ptr<Bin>> bins;
ref_ptr<ViewDependentState> viewDependentState;

protected:
virtual ~RecordTraversal();
};

} // namespace vsg
Loading
Loading