fix vsgMacros.cmake#1675
Merged
Merged
Conversation
## macro: vsg_add_cmake_support_files - missing: export( EXPORT ) Cmake statement - results: - in-tree builds not working properly - FetchContent does not work with vsg - fix: simply added corresponding CMake command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: fix vsg cmake macro "vsg_add_cmake_support_files"
Description
The macro vsg_add_cmake_support_files is missing an
export( EXPORT )CMake statement.Fixes # no issue created, simply fixed it.
Type of change
How Has This Been Tested?
Create a repo, use CMake FetchContent to get current vsg into the build. Even if all works out well, linking the executable / library to vsg::vsg FAILS.
Create a repo with submodule(s) vsg (and maybe vsgImGui), try to link own executable to vsg::vsg after including vsg via add_subdirectory() → FAILS.
In In-Tree case: this works directly
But it is not a "pro" solution, as this line of code belongs into that macro!
Checklist: