fix warnings about automatic conversion from size_t to uint32_t#18
Merged
Conversation
Owner
|
I think the better fix would be to use C++ style static_cast<uint32_t> rather than C style cast (uint32_t). It should be possible to do search and replace of the (uint32_t), I can do this post merge, but it would probably be better done prior to merging. Could you change this? Thanks. |
Contributor
Author
|
ok, I will change that. |
05d81f2 to
4aee1ea
Compare
Contributor
Author
|
Changed to static_cast<uint32_t>( ) |
Owner
|
Thanks. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes Compiler warning:
warning C4267: '=': conversion from 'size_t' to 'uint32_t', possible loss of data
added c-style casts to unint32_t - mostly for the results of vector.size() that are of type std::size_t
Most seem to be required to be uint32_t for the vulcan api, except those in
src/vsg/vk/Descriptor.cpp (width,height,depth) that describe image dimensions. Those could be defined as size_t themselves, but I guessed leaving the 32bit limit on a single dimension is still reasonable.
Trying to get things running I found a few problems on win32, and to avoid duplicate work I would like to submit my fixes for merging. As I don't have an executable build yet, nothing is tested.
Regards, Laurens.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: