Added MacOS_Window#23
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added native macOS window support. Moved the initialisation of device, physical device etc into vsg::Window. Traits is now a vsg::Object and a refptr is trained in Window.
Take extra note of the inclusion of finalBackWidth, finalBackingHeight. Platforms that support HDPI screens can have a different coord space for windows and the actual backing/pixel/frame buffers that we render into. So on macOS we can request a window of 800x600. With no hdpi we get buffer of 800x600 pixels. With HDPI (retian screens etc), we get a window of 800x600 but the buffer is 1600x1200.
Not sure what to call it at this point but it's important so we can set the correct viewport. I've updated vsgdraw to use the traits finalBackingWidth/height when setting the viewport.
Type of change
Example creating windows will now need to pass a vsg::ref_ptrWindows::Traits object to the Window create function
How Has This Been Tested?
Built and run on macOS 10.13.5. using XCode 9.4.1