Skip to content

View dir location change #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertosfield merged 2 commits into from
Sep 9, 2025
Merged

View dir location change #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fa2bb2
Changed the viewDir location to avoid overlaping with texCoord array
robertosfield Sep 9, 2025
1a53532
Changed location of viewDir and texCoord[] to avoid location overlaps.
robertosfield Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data/shaders/standard.vert
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ layout(set = MATERIAL_DESCRIPTOR_SET, binding = 12) readonly buffer JointMatrice
layout(location = 0) out vec3 eyePos;
layout(location = 1) out vec3 normalDir;
layout(location = 2) out vec4 vertexColor;
layout(location = 3) out vec2 texCoord[VSG_TEXCOORD_COUNT];
layout(location = 6) out vec3 viewDir;
layout(location = 3) out vec3 viewDir;
layout(location = 4) out vec2 texCoord[VSG_TEXCOORD_COUNT];

out gl_PerVertex{
vec4 gl_Position;
Expand Down
2 changes: 1 addition & 1 deletion data/shaders/standard_flat_shaded.frag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ layout(set = MATERIAL_DESCRIPTOR_SET, binding = 11) uniform TexCoordIndices
} texCoordIndices;

layout(location = 2) in vec4 vertexColor;
layout(location = 3) in vec2 texCoord[VSG_TEXCOORD_COUNT];
layout(location = 4) in vec2 texCoord[VSG_TEXCOORD_COUNT];

layout(location = 0) out vec4 outColor;

Expand Down
4 changes: 2 additions & 2 deletions data/shaders/standard_pbr.frag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ layout(set = VIEW_DESCRIPTOR_SET, binding = 0) uniform LightData
layout(location = 0) in vec3 eyePos;
layout(location = 1) in vec3 normalDir;
layout(location = 2) in vec4 vertexColor;
layout(location = 3) in vec2 texCoord[VSG_TEXCOORD_COUNT];
layout(location = 6) in vec3 viewDir;
layout(location = 3) in vec3 viewDir;
layout(location = 4) in vec2 texCoord[VSG_TEXCOORD_COUNT];

layout(location = 0) out vec4 outColor;

Expand Down
4 changes: 2 additions & 2 deletions data/shaders/standard_phong.frag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ layout(set = VIEW_DESCRIPTOR_SET, binding = 0) uniform LightData
layout(location = 0) in vec3 eyePos;
layout(location = 1) in vec3 normalDir;
layout(location = 2) in vec4 vertexColor;
layout(location = 3) in vec2 texCoord[VSG_TEXCOORD_COUNT];
layout(location = 6) in vec3 viewDir;
layout(location = 3) in vec3 viewDir;
layout(location = 4) in vec2 texCoord[VSG_TEXCOORD_COUNT];

layout(location = 0) out vec4 outColor;

Expand Down