feat: support custom metric types#44
Closed
dsze wants to merge 1 commit into
Closed
Conversation
Other statsd backends (e.g. Datadog, netdata) support metric types beyond those supported by the original Etsy statsd daemon. For example: * Histograms (type "h") which are like Timers, but with different units. * Dictionaries (type "d") which are like Sets but also record a count for each unique value. Since these are non-standard, add a `custom()` method, where the metric type is passed in by the caller, assuming that they know the capabilities of the backend they are using.
Collaborator
|
@dsze i think when adding this feature it would be nice to add a section to the readme that shows how to use it and why its there. when i first started working on this project i also wondered about adding the non-standard extensions but eventually removed them from my pr. at any rate, this is a good way to allow for full flexibility so it'd be great to document why someone would want this (ie the two examples above) |
Contributor
Author
|
See #45 instead. Had to close this PR because it was created off of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other statsd backends (e.g. Datadog, netdata) support metric types beyond
those supported by the original Etsy statsd daemon. For example:
Histograms (type "h") which are like Timers, but with different units.
Dictionaries (type "d") which are like Sets but also record a count for
each unique value.
Since these are non-standard, add a
custom()method, where the metrictype is passed in by the caller, assuming that they know the capabilities
of the backend they are using.