Skip to content

fix(suspense): clear placeholder and fallback el refs after resolved to enable GC #13928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edison1105 merged 5 commits into from
Nov 5, 2025
Merged

fix(suspense): clear placeholder and fallback el refs after resolved to enable GC #13928

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
588de48
fix(Suspense): reset vnode.placeholder to null when removing placeholder
edison1105 Sep 26, 2025
c68204a
Merge branch 'main' into edison/fix/asyncComponentPlaceholder
edison1105 Nov 5, 2025
d3109ee
fix(Suspense): clear el reference from fallback vnode to allow garbag…
edison1105 Nov 5, 2025
9954f45
fix(Suspense): clear el reference from fallback vnode to allow garbag…
edison1105 Nov 5, 2025
cd706a4
chore: Merge branch 'edison/fix/asyncComponentPlaceholder' of https:/…
edison1105 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/runtime-core/src/components/Suspense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,7 @@ function createSuspenseBoundary(
effects,
parentComponent,
container,
isInFallback,
} = suspense

// if there's a transition happening we need to wait it to finish.
Expand All @@ -551,6 +552,10 @@ function createSuspenseBoundary(
MoveType.ENTER,
)
queuePostFlushCb(effects)
// clear el reference from fallback vnode to allow GC after transition
if (isInFallback && vnode.ssFallback) {
vnode.ssFallback.el = null
}
}
}
}
Expand All @@ -570,6 +575,11 @@ function createSuspenseBoundary(
anchor = next(activeBranch)
}
unmount(activeBranch, parentComponent, suspense, true)
// clear el reference from fallback vnode to allow GC
// only clear immediately if there's no delayed transition
if (!delayEnter && isInFallback && vnode.ssFallback) {
vnode.ssFallback.el = null
}
}
if (!delayEnter) {
// move content from off-dom container to actual container
Expand Down Expand Up @@ -728,6 +738,8 @@ function createSuspenseBoundary(
optimized,
)
if (placeholder) {
// clean up placeholder reference
vnode.placeholder = null
remove(placeholder)
}
updateHOCHostEl(instance, vnode.el)
Expand Down
Loading