Skip to content

fix(runtime-core): avoid unexpected cancelled parameter in transition done callback #14391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edison1105 merged 2 commits into from
Feb 9, 2026
+6 −4
Merged

fix(runtime-core): avoid unexpected cancelled parameter in transition done callback #14391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4768e8f
fix: avoid unexpected `cancelled` parameter in transition `done` call…
KazariEX Feb 2, 2026
d792797
Merge branch 'main' into fix/transition-done-cancelled
edison1105 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/runtime-core/src/components/BaseTransition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ export function resolveTransitionHooks(
}
}
let called = false
const done = (el[enterCbKey] = (cancelled?) => {
el[enterCbKey] = (cancelled?) => {
if (called) return
called = true
if (cancelled) {
Expand All @@ -425,7 +425,8 @@ export function resolveTransitionHooks(
hooks.delayedLeave()
}
el[enterCbKey] = undefined
})
}
const done = el[enterCbKey]!.bind(null, false)
if (hook) {
callAsyncHook(hook, [el, done])
} else {
Expand All @@ -443,7 +444,7 @@ export function resolveTransitionHooks(
}
callHook(onBeforeLeave, [el])
let called = false
const done = (el[leaveCbKey] = (cancelled?) => {
el[leaveCbKey] = (cancelled?) => {
if (called) return
called = true
remove()
Expand All @@ -456,7 +457,8 @@ export function resolveTransitionHooks(
if (leavingVNodesCache[key] === vnode) {
delete leavingVNodesCache[key]
}
})
}
const done = el[leaveCbKey]!.bind(null, false)
leavingVNodesCache[key] = vnode
if (onLeave) {
callAsyncHook(onLeave, [el, done])
Expand Down
Loading