test(compiler-core): add test for identifier collision#7078
Closed
znck wants to merge 1 commit intovuejs:mainfrom
Closed
test(compiler-core): add test for identifier collision#7078znck wants to merge 1 commit intovuejs:mainfrom
znck wants to merge 1 commit intovuejs:mainfrom
Conversation
❌ Deploy Preview for vuejs-coverage failed.
|
Member
yyx990803
pushed a commit
that referenced
this pull request
Mar 28, 2023
IAmSSH
pushed a commit
to IAmSSH/core
that referenced
this pull request
May 14, 2023
…f regex (vuejs#7068) closes vuejs#7038 closes vuejs#7041 closes vuejs#7078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not use local alias when we rewrite
export { foo as default } ...toimport { foo } ..., this could result in identifier collision.Depends on #7608 as it changes rewrite logic.
@sxzz maybe you can pull this in your PR.