Skip to content

fix(overlay): ARIA attributes for buttons #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skirtles-code wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(overlay): ARIA attributes for buttons #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/overlay/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,13 @@ const { getIframe } = useIframe(clientUrl, async () => {
<!-- panel -->
<div ref="panelEle" class="vue-devtools__panel" :style="panelStyle" @pointerdown="onPointerDown">
<div
class="vue-devtools__anchor-btn panel-entry-btn" title="Toggle Vue DevTools" aria-label="Toggle devtools panel"
:style="panelVisible ? '' : 'filter:saturate(0)'" @click="togglePanelVisible"
role="button"
class="vue-devtools__anchor-btn panel-entry-btn"
title="Toggle Vue DevTools"
aria-label="Toggle devtools panel"
:aria-pressed="panelVisible"
:style="panelVisible ? '' : 'filter:saturate(0)'"
@click="togglePanelVisible"
>
<svg viewBox="0 0 256 198" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill="#41B883" d="M204.8 0H256L128 220.8L0 0h97.92L128 51.2L157.44 0h47.36Z" />
Expand All @@ -129,8 +134,11 @@ const { getIframe } = useIframe(clientUrl, async () => {
<template v-if="vueInspectorSupported">
<div class="vue-devtools__panel-content vue-devtools__panel-divider" />
<div
role="button"
class="vue-devtools__anchor-btn vue-devtools__panel-content vue-devtools__inspector-button"
title="Toggle Component Inspector"
aria-label="Toggle component inspector"
:aria-pressed="vueInspectorEnabled"
:class="{ active: vueInspectorEnabled }"
@click="toggleVueInspector"
>
Expand Down
Loading