Skip to content

fix(ui): use accessible close buttons #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pupuking723 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −4
Open

fix(ui): use accessible close buttons #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/ui/src/components/Dialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,15 @@ onMounted(() => isMount.value = true)
{{ props.title }}
</slot>
</div>
<div v-if="closable" class="h6 w6 $ui-fcc cursor-pointer rounded-full transition-colors hover:bg-primary-100 dark:hover:bg-gray-700" @click="close">
<div class="i-carbon-close" />
</div>
<button
v-if="closable"
type="button"
aria-label="Close dialog"
class="h6 w6 $ui-fcc cursor-pointer rounded-full border-none bg-transparent p0 transition-colors hover:bg-primary-100 dark:hover:bg-gray-700"
@click="close"
>
<div class="i-carbon-close" aria-hidden="true" />
</button>
</div>
<div class="content transition-all transition-duration-300">
<slot />
Expand Down
10 changes: 9 additions & 1 deletion packages/ui/src/components/Drawer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,15 @@ onMounted(() => isMount.value = true)
class="drawer pointer-events-auto absolute min-w-25 of-auto $ui-border-base transition-transform transition-duration-300"
@click.stop
>
<div v-if="closable" class="i-carbon-close absolute right-1.5 top-1.5 $ui-z-max cursor-pointer p1 text-lg $ui-text" @click="show = false" />
<button
v-if="closable"
type="button"
aria-label="Close drawer"
class="absolute right-1.5 top-1.5 $ui-z-max cursor-pointer border-none bg-transparent p1 text-lg $ui-text"
@click="show = false"
>
<div class="i-carbon-close" aria-hidden="true" />
</button>
<slot />
</div>
</Overlay>
Expand Down