perf: drop execa - #964
Merged
Merged
Conversation
✅ Deploy Preview for vue-devtools-docs canceled.
|
webfansplz
approved these changes
Sep 15, 2025
Member
|
Thanks for the PR, can you help to resolve the conflicts? |
We don't actually use it in the main vite package, so that one is an easy win. In the electron package, we use it only to launch a well known path, i.e. we don't use any features of `execa`. So we should be able to switch to using the built in `child_process` module directly.
Contributor
Author
|
should be caught up now 👍 |
@vue/devtools-applet
@vue/devtools-core
@vue/devtools
@vue/devtools-api
@vue/devtools-kit
vite-plugin-vue-devtools
commit: |
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't actually use it in the main vite package, so that one is an
easy win.
In the electron package, we use it only to launch a well known path,
i.e. we don't use any features of
execa. So we should be able toswitch to using the built in
child_processmodule directly.Note: I think we need
shell: trueon windows to launch bins that may be.cmdfiles. If I'm wrong, let me know and we can set it tofalseunconditionally.I tried this on WSL and regular windows, and it seems to work