feat(no-empty-component-block): support auto fix#2595
Merged
FloEdelmann merged 13 commits intovuejs:masterfrom Nov 11, 2024
Merged
feat(no-empty-component-block): support auto fix#2595FloEdelmann merged 13 commits intovuejs:masterfrom
FloEdelmann merged 13 commits intovuejs:masterfrom
Conversation
ota-meshi
requested changes
Nov 11, 2024
ota-meshi
reviewed
Nov 11, 2024
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
…ue into feat/add-auto-fix
FloEdelmann
requested changes
Nov 11, 2024
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
waynzh
changed the title
FloEdelmann
reviewed
Nov 11, 2024
FloEdelmann
approved these changes
Nov 11, 2024
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
LGTM now. Thanks @waynzh!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #2564
Add support for automatically deleting empty blocks.
Chose this approach is because I couldn't find a better way to handle reporting & fixing eachemptyBlockwithin a for loop, as removing the first block will affect the range of the second block😵💫.UPDATE: Due to lack of whitespaces in test cases.