Skip to content

fix(valid-define-options): Allow the use of simple constants#2920

Merged
FloEdelmann merged 10 commits intovuejs:masterfrom
FrontEndDog:feat/valid-define-options
Sep 3, 2025
Merged

fix(valid-define-options): Allow the use of simple constants#2920
FloEdelmann merged 10 commits intovuejs:masterfrom
FrontEndDog:feat/valid-define-options

Conversation

@FrontEndDog
Copy link
Copy Markdown
Contributor

@FrontEndDog FrontEndDog commented Aug 29, 2025

Fixes #2919

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 29, 2025

🦋 Changeset detected

Latest commit: 9536f05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FrontEndDog FrontEndDog changed the title feat(valid-define-options): Add allowVariableNamePattern fix(valid-define-options): Allow the use of string constants Sep 2, 2025
@FloEdelmann FloEdelmann marked this pull request as draft September 2, 2025 12:13
@FrontEndDog FrontEndDog changed the title fix(valid-define-options): Allow the use of string constants fix(valid-define-options): Allow the use of simple constants Sep 3, 2025
@FrontEndDog FrontEndDog marked this pull request as ready for review September 3, 2025 03:52
Comment thread lib/rules/valid-define-options.js Outdated
@FrontEndDog

This comment was marked as resolved.

@FloEdelmann

This comment was marked as resolved.

@FloEdelmann

This comment was marked as resolved.

Copy link
Copy Markdown
Member

@waynzh waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@FloEdelmann FloEdelmann merged commit a5127b0 into vuejs:master Sep 3, 2025
15 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 3, 2025
@FrontEndDog FrontEndDog deleted the feat/valid-define-options branch January 28, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support literal constant references in vue/valid-define-options rule

3 participants