Skip to content

test(tsc): add tests for #3779, #3820#3838

Merged
johnsoncodehk merged 12 commits intovuejs:masterfrom
so1ve-forks:fix/issue-3779-3820
Aug 25, 2024
Merged

test(tsc): add tests for #3779, #3820#3838
johnsoncodehk merged 12 commits intovuejs:masterfrom
so1ve-forks:fix/issue-3779-3820

Conversation

@so1ve
Copy link
Member

@so1ve so1ve commented Jan 2, 2024

fixes #3779, fixes #3820

@johnsoncodehk
Copy link
Member

Sorry for the delay, I think this problem is best solved by defineComponent itself, have you tried its feasibility?

@so1ve
Copy link
Member Author

so1ve commented Mar 20, 2024

I didn't try this approach, but I think making changes to defineComponent is doable 👍

@johnsoncodehk
Copy link
Member

#3779, #3820 should have been resolved via vuejs/core#10801 + 68edc1d.

I reverted the PR's fix but kept the tests, but there are some other tests that are broken due to a regression in Vue 3.5, so they can't be merged for now.

@johnsoncodehk johnsoncodehk force-pushed the master branch 2 times, most recently from 31e60a3 to b7fdfc3 Compare May 10, 2024 22:42
@johnsoncodehk johnsoncodehk force-pushed the master branch 12 times, most recently from a94cf79 to e2cedb6 Compare June 30, 2024 00:20
@johnsoncodehk johnsoncodehk force-pushed the master branch 7 times, most recently from c6cab9a to ab8df96 Compare July 4, 2024 08:29
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: 3584e49

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@3838

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@3838

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@3838

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@3838

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@3838

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@3838

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@3838

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@3838

Open in Stackblitz

@johnsoncodehk johnsoncodehk changed the title fix: use definition from defineProps if possible test: add tests for #3779, #3820 Aug 25, 2024
@johnsoncodehk johnsoncodehk changed the title test: add tests for #3779, #3820 test(tsc): add tests for #3779, #3820 Aug 25, 2024
@johnsoncodehk johnsoncodehk merged commit de50847 into vuejs:master Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic props inference in template breaks when directly referring to prop by name Optional props are incorrectly typed in <template>

3 participants