Pass attributes to parseComponent (addresses #4914)#4925
Merged
Pass attributes to parseComponent (addresses #4914)#4925
Conversation
Contributor
Author
|
Tests are incoming. |
Member
|
The |
Contributor
Author
|
Ahhh! I can't believe I missed that. >_> Sorry about that, yeah, I absolutely will. |
Contributor
Author
|
@yyx990803 do you want me to undo the changes I made to build.js? |
Member
|
yes please |
Contributor
Author
|
done. Also, there's only one test... I can certainly add more if desired. |
Contributor
Author
|
I added an extra check just for good measure. It's ready for review now. |
posva
approved these changes
Feb 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4914
This PR passes attributes down to
parseComponentso that build tools layered on top ofvue-template-compilercan have access to that information without having to parse the src to retrieve it.