fix #8041: templates inside v-pre should be rendered to HTML#8146
Merged
fix #8041: templates inside v-pre should be rendered to HTML#8146
Conversation
Contributor
Author
|
Any feedback on this PR? No pressure as I know how hard it is as a maintainer - I'm just excited to learn more about the Vue codebase and tackling issues is the best way I know to do that. Will happily take feedback on approach, style, or anything else. |
haoqunjiang
approved these changes
Jun 14, 2018
|
It is strange that they do not approve this changes. Component |
|
@kball @yyx990803 has this regressed? If I create a new fiddle it still repros. Or is this change not in 2.6.10? I'm encountering this issue as posted here, so I want to know how I can get a version with this fix. Thanks! |
This was referenced Oct 16, 2019
|
@alekseymvt @michael-hawker see this issue: #10717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #8041
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
I don't believe this is breaking as content inside of
v-preis considered to be static. However it does change the outputted static content in the case where a<template>tag is labeled withv-preor inside of av-preelement.The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I pushed a 'compiled' version of this to a different branch to show the working behavior on jsFiddle. The original fiddle from issue #8041: https://jsfiddle.net/zct418xa/1/
A fiddle with the updated behavior using vue.js compiled from this change: https://jsfiddle.net/f7nv9218/