fix($theme-default): close dropdown-links when focusout on the last item (close #1948)#1952
Merged
ulivz merged 2 commits intovuejs:masterfrom Oct 21, 2019
haoranpb:fix/dropdown-links-wont-toggle-on-last
Merged
fix($theme-default): close dropdown-links when focusout on the last item (close #1948)#1952ulivz merged 2 commits intovuejs:masterfrom haoranpb:fix/dropdown-links-wont-toggle-on-last
ulivz merged 2 commits intovuejs:masterfrom
haoranpb:fix/dropdown-links-wont-toggle-on-last
Conversation
Collaborator
|
Hi @ludanxer, Thanks for your work. What you did fixed the bug, however I think that it was hard to understand ( |
kefranabg
approved these changes
Oct 14, 2019
Contributor
Author
|
You make it way more readable! |
billyyyyy3320
approved these changes
Oct 19, 2019
ulivz
approved these changes
Oct 21, 2019
|
Hey @ludanxer, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1948
Logic is a little complicated here. Someone please do test this again.
When people use tab to focusout the last item, the dropdown-links should be closed since the
openclass is surely active.When people use mouse to focusout the last item, however, the
openclass may not be active.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: