This repository was archived by the owner on Apr 8, 2025. It is now read-only.
Fix PXE booting helium#1
Merged
Conversation
added 3 commits
September 3, 2016 08:39
This fixes using fetch= to load filesystem.squashfs over HTTP. You can tell do_netmount in scripts/live needs DEVICE to be set, but the only place it is ever set is in configure_networking() and that's not called anywhere in the code. That's a bug. This is the essentially the same fix used in recent versions of this package: at the top of do_netmount there is a call to do_netsetup which is pretty much a renamed configure_networking. I can't help but wonder if this ever worked at all in Debian. Anyway.
Original code is broken and will not parse e.g.: tftp://192.168.0.1/vyos/filesystem.squashfs correctly. This was lifted from a more recent version of this script in a newer package.
Contributor
|
Looks good at a glance. I guess we really should do 1.1.8 release before 1.2.0, with this included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So if one naively tries to boot vyos over PXE by copying the append line in the isolinux config and then adding fetch=http://foo/filesystem.squashfs, one gets a kernel panic, presumably because the shell exits or crashes.
After much debugging, it turns out that the code that deals with fetch= does not setup networking first, so it never succeeds.
This pull request fixes that.
I also noticed that tftp:// URLs to fetch= were broken, so I backported the fix.