Skip to content

Mark transactions inactive during key serialization #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nolanlawson wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Mark transactions inactive during key serialization #479

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ad8e2d3
Mark transactions inactive during key serialization
nolanlawson Oct 25, 2025
d3854a0
Remove unnecessary whitespace change
nolanlawson Oct 25, 2025
8d77e51
Remove mistaken duplicate line
nolanlawson Oct 25, 2025
6ca912c
Add IDBCursor continue/continuePrimaryKey
nolanlawson Oct 27, 2025
ddf2e81
Fix wording
nolanlawson Oct 27, 2025
ba5d18b
Refactor to prefer the with-transaction logic
nolanlawson Nov 9, 2025
b82c2db
Refactor more related methods
nolanlawson Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Mark transactions inactive during key serialization
  • Loading branch information
@nolanlawson
nolanlawson committed Oct 25, 2025
commit ad8e2d39f133238b43c69850ac646f6e9600912b
12 changes: 12 additions & 0 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3010,13 +3010,25 @@ To <dfn>add or put</dfn> with |handle|, |value|, |key|, and |no-overwrite flag|,

1. If |key| was given, then:

1. [=/Assert=]: |transaction|'s [=transaction/state=] is [=transaction/active=].

1. Set |transaction|'s [=transaction/state=] to [=transaction/inactive=].

NOTE:
The [=/transaction=] is made [=transaction/inactive=] so that getters or other side effects triggered by the cloning operation are unable to make additional requests against the transaction.

1. Let |r| be the result of [=/converting a
value to a key=] with |key|. Rethrow any exceptions.

1. Set |transaction|'s [=transaction/state=] to [=transaction/active=].

1. If |r| is "invalid value" or "invalid type", [=exception/throw=] a "{{DataError}}" {{DOMException}}.

1. Let |r| is "invalid value" or "invalid type", [=exception/throw=] a "{{DataError}}" {{DOMException}}.

1. Let |key| be |r|.


1. Let |targetRealm| be a user-agent defined [=ECMAScript/Realm=].

1. Let |clone| be a [=clone=] of |value| in |targetRealm| during |transaction|.
Expand Down