Closed
Conversation
Assign stable ID to blank nodes, to have a more stable changeset. Note that it is recommended that a blank node should be anonymous and it is discouraged to rely on its ID. We should review if it is ok to make the IDs stable in our context. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
Author
|
Sorry. This is a mistake. Was meant to test this only with my own repo. |
Collaborator
|
@bact thanks for thinking about this, though I think the code is getting complicated for what should be a simple task. Blank nodes famously don't have stable IDs, and we're only going to have complications if we try to assign them some. So instead, how about we create local IDs for each contributor e.g. |
Collaborator
Author
|
Local IDs should do. Probably the same applies for source web pages. |
Collaborator
|
Yes, good point re. webpages. Let's create this as an issue, and I think this will make life easier for anyone generating the code, so should be prioritised. |
coolharsh55
added a commit
that referenced
this pull request
Apr 7, 2025
- #273 use DPV_VERSION in links - #274 stable BNode ids for contributors, orgs, sources - #271 typos in references - #265 -- same as #274 - changes affect all RDF and HTML - this commit should be the last commit where random BNodes are used for person etc. and the subsequent commits should be cleaner Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request