Black on black consistent in dark (high contrast) theme #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a real black instead of grey in the dark contrast theme for the app bar. Also remove the black square in the navigation bar for the selected item and instead use grey to highlight it. This was done by changing the primary color of the theme and not changing the background attribute in the theme to not always be black.
Because the space behind the items isn't black anymore, a grey was used as the icon and text color of the selected navbar item. Fixes wallabag#552
Only change the text color for this theme and not for the other ones.
Strubbl
reviewed
Sep 13, 2018
| <item name="android:background">#000000</item> | ||
| <item name="android:windowBackground">@color/darkContrastBlack</item> | ||
| <item name="android:textColor">#FFFFFF</item> | ||
| <item name="colorPrimary">#000000</item> |
Contributor
There was a problem hiding this comment.
does it make sense to use @color/darkContrastBlack instead of the hex code?
Contributor
Author
There was a problem hiding this comment.
I thought it would be easier to change the colors afterwards when they are stored in a variable. However, I can change the hex codes to the color variables to make everything uniform.
Contributor
Author
|
So is there a problem with the commit? |
Strubbl
approved these changes
Feb 12, 2019
Contributor
Strubbl
left a comment
Strubbl
left a comment
There was a problem hiding this comment.
Thanks for the fix. Works fine.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #552
Adjust color settings in this theme to use black/grey in the right situations for the app bar and the navigation bar. Also add a new color for the text of highlighted items in the navigation bar for this theme.