Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Knowledgebase navigation updateNo updates to support articles, tag pages, or product indexes from this run. |
Contributor
📚 Mintlify Preview Links📝 Changed (2 total)⚙️ Other (2)
🤖 Generated automatically when Mintlify deployment succeeds |
mdlinville
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs the Knowledgebase Nav generator (
scripts/knowledgebase-nav/) with the CoreWeave-aligned utility: Mintlify root and badge styling come fromconfig.yaml, the--repo-rootCLI is removed, and docs/tests are updated so the tool reads as a reusable Mintlify docs utility rather than a hard-codedwandb-docs-only layout.Motivation / context
We are planning to unify this utility with the CoreWeave version as part of the Q2 DocEngine plans. This unites the script across those two repos, with the only difference being the config.yaml file in each. Future updates can stay in sync, or be pulled from DocEngine.
public-docs).orange.Changes
Configuration (
config.yaml)mintlify_root: path from the GitHub repository root to the directory that containssupport/andsupport.mdx(this repo uses".").badge_color: Mintlify<Badge>color (default used in code when missing:"blue"; this repo sets"orange"to preserve prior appearance).generate_tags.pyresolve_mintlify_root(): readsmintlify_rootfrom the loaded config, resolved relative to the GitHub repo root (three parents up from the script path:…/scripts/knowledgebase-nav/→ repo root).main(): drops--repo-root; optional--configonly (defaults toconfig.yamlnext to the script). Callsresolve_mintlify_rootthenrun_pipeline(repo_root, config_path).badge_colorflows through tab badges, footers, product index template rendering, and featured section updates.templates_root: computed path oftemplates/relative to the repo root, passed into Jinja so generated MDXtemplate:metadata is not hard-coded toscripts/knowledgebase-nav/....plain_textdoctest examples use neutral names/URLs).pr_report.py--repo-root;git_diff_name_status_headruns with cwd set to the Mintlify root from_resolve_mintlify_root(config_path)(logic duplicated fromgenerate_tagsintentionally for standalone imports).DEFAULT_CONFIG_PATH:Path(__file__).resolve().parent / "config.yaml".--config: help text updated for new behavior.Jinja templates
support_tag.mdx.j2andsupport_product_index.mdx.j2: dynamictemplate:path andbadge_colorfor Badges.GitHub Actions (
.github/workflows/knowledgebase-nav.yml)python .../generate_tags.pyandpr_report.pywithout--repo-root.mintlify_rootin config.Documentation
README.mdandArchitecture.md: describe generic<utility>/knowledgebase-nav/placement, Mintlify root resolution, workflow path filters in terms of Mintlifysupport/**and the utility directory; local run instructions updated; examples use simplified display names in snippets where appropriate.Tests
test_generate_tags.py:mintlify_root/badge_colorin fixtures; all updated call sites for new keyword-only parameters; template provenance constant; display name and plain-text test tweaks.test_golden_output.py: golden root =resolve_mintlify_root(CONFIG_PATH)instead of assuming repo layout viaparent.parent.parent.parent.test_pr_report.py: expectations aligned with shortened example display names (Models,Weave).Breaking changes
generate_tags.py:--repo-rootremoved. Setmintlify_rootinconfig.yaml(required).pr_report.py:--repo-rootremoved; git diff runs from the resolved Mintlify root. Any custom invocation must pass--configif config is not beside the script.Migration notes
config.yaml:mintlify_root(use"."ifsupport/andsupport.mdxare at the repo root) and optionallybadge_color.python .../generate_tags.py --repo-root .withpython .../generate_tags.py(and same forpr_report.pyin CI or local scripts).How to test / verify
pytest scripts/knowledgebase-nav/tests/test_generate_tags.py -vpytest scripts/knowledgebase-nav/tests/test_pr_report.py -vpytest scripts/knowledgebase-nav/tests/test_golden_output.py -v -m integration(requires real tree at resolved Mintlify root; skips if
support.mdxmissing.)support/**orscripts/knowledgebase-nav/**and confirm Knowledgebase Nav runs without--repo-rootand PR comments still listdocs.jsonupdates when tag pages change.Risk / review focus
resolve_mintlify_root/_resolve_mintlify_root: must stay consistent betweengenerate_tags.pyandpr_report.py(called out in code); repo-root assumption is three levels aboveknowledgebase-navscripts.mintlify_rootis missing, both tools fail fast with a clear error (verify config is committed and valid).mintlify_rootmatching this repo’s layout; changing config path semantics later should re-run golden suite.Stats
d7b94e586— Sync kb-nav script with CoreWeaveorigin/main