Skip to content

feat: Allow the operator to support installation without cluster level permissions #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielpanzella merged 6 commits into from
Jul 29, 2024
Merged

feat: Allow the operator to support installation without cluster level permissions #16

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92459e1
feat: Allow deploying operator without global cluster permissions
danielpanzella Jul 26, 2024
6cabca8
fix: missing permission in kubebuilder annotation
danielpanzella Jul 26, 2024
670e832
fix: remove extraneous permissions
danielpanzella Jul 26, 2024
dff56b1
fix: remove metrics related patches
danielpanzella Jul 26, 2024
c6f093a
fix: missed a permission
danielpanzella Jul 26, 2024
6e578c6
fix: add updated permissions to kubekuilder annotations
danielpanzella Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: missed a permission
  • Loading branch information
@danielpanzella
danielpanzella committed Jul 26, 2024
commit c6f093ac3c90d7a1771762de94d7e7ddef602088
12 changes: 1 addition & 11 deletions config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,7 @@ rules:
- events
verbs:
- create
- apiGroups:
- app
resources:
- deployments
verbs:
- create
- delete
- get
- list
- update
- watch
- patch
- apiGroups:
- apps.wandb.com
resources:
Expand Down
2 changes: 1 addition & 1 deletion controllers/weightsandbiases_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ type WeightsAndBiasesReconciler struct {
//+kubebuilder:rbac:groups=apps.wandb.com,resources=weightsandbiases/status,verbs=get;update;patch
//+kubebuilder:rbac:groups=apps.wandb.com,resources=weightsandbiases/finalizers,verbs=update
//+kubebuilder:rbac:groups="",resources=secrets;configmaps,verbs=update;delete;get;list;create;watch
//+kubebuilder:rbac:groups="",resources=events,verbs=create
//+kubebuilder:rbac:groups="",resources=events,verbs=create;patch

// Reconcile is part of the main kubernetes reconciliation loop which aims to
// move the current state of the cluster closer to the desired state.
Expand Down