feat(weave): dogfood calls_complete on wandb-entity projects#6644
Open
gtarpenning wants to merge 1 commit intomasterfrom
Open
feat(weave): dogfood calls_complete on wandb-entity projects#6644gtarpenning wants to merge 1 commit intomasterfrom
gtarpenning wants to merge 1 commit intomasterfrom
Conversation
HiveMind Sessions1 session · 20m · $6.17
View all sessions in HiveMind → Run |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=1a47518ba35f81a5ec4842ba469f145eee30ed4a |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| """ | ||
|
|
||
| use_calls_complete: bool = False | ||
| use_calls_complete: bool = True |
Collaborator
There was a problem hiding this comment.
Wont this immediately break users logging to an existing non-calls-complete project?
Member
Author
There was a problem hiding this comment.
no, the complete processor logs to calls_merged projects too.
Adds a CALLS_COMPLETE_ENTITY_ALLOWLIST gate so entities in the allowlist (currently just "wandb") auto-opt-in to the calls_complete write path regardless of WEAVE_USE_CALLS_COMPLETE. Entity is threaded from weave.init() through to RemoteHTTPTraceServer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gtarpenning
force-pushed
the
default-calls-complete
branch
from
fdf215f to
32d89c2
Compare
gtarpenning
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pivots from "flip
WEAVE_USE_CALLS_COMPLETEdefault to true" to an entity-based dogfood gate. Entities inCALLS_COMPLETE_ENTITY_ALLOWLIST(currently{"wandb"}) auto-opt-in to the calls_complete write path regardless of the env var; everyone else stays on the legacy default.Why: lets us validate calls_complete on wandb/* traffic first — if it explodes, it's our people, not customers. Flipping the env default remains a follow-up once we have confidence.
Entity is threaded from
weave.init()→init_weave_get_server→RemoteHTTPTraceServer.StainlessRemoteHTTPTraceServerdoes not use this path and is unaffected.