feat(weave): fold feedback into agent chat-view responses via include_feedback#6686
Draft
nikumar1206 wants to merge 2 commits intonikhil/feedback-helperfrom
Draft
feat(weave): fold feedback into agent chat-view responses via include_feedback#6686nikumar1206 wants to merge 2 commits intonikhil/feedback-helperfrom
nikumar1206 wants to merge 2 commits intonikhil/feedback-helperfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=2b458b7aab42dd3c27d8e97999f3669e850a6e8a |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nikumar1206
force-pushed
the
nikhil/feedback-helper
branch
from
f79deec to
fb7cae6
Compare
nikumar1206
force-pushed
the
nikhil/chat-view-feedback-foldin
branch
2 times, most recently
from
90af7e8 to
37069c1
Compare
nikumar1206
force-pushed
the
nikhil/feedback-helper
branch
2 times, most recently
from
2595246 to
f9a7ac8
Compare
nikumar1206
force-pushed
the
nikhil/chat-view-feedback-foldin
branch
from
7f1fdb3 to
e624142
Compare
nikumar1206
force-pushed
the
nikhil/chat-view-feedback-foldin
branch
from
e624142 to
f81149e
Compare
nikumar1206
force-pushed
the
nikhil/feedback-helper
branch
from
f9a7ac8 to
5aff0f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Third of three stacked PRs for Phase 1 of human feedback on agent turns.
Adds `include_feedback: bool` to `agent_traces_chat` and `agent_conversation_chat`. When true, the handler runs one batched feedback query and folds results: turn feedback onto the turn, step feedback onto each message by span_id, conversation feedback onto the conversation.
Mirrors the pattern from `CallsQueryReq.include_feedback` — two queries, merged in Python, not a JOIN.
Stack: #6684 → #6685 → this
Testing