Skip to content

feat(warp): allow registering alternate CLI agents via WARP_CLI_AGENT_NAME #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aovestdipaperino wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(warp): allow registering alternate CLI agents via WARP_CLI_AGENT_NAME #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugins/warp/scripts/build-payload.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ negotiate_protocol_version() {
fi
}

# Agent slug reported to Warp in the payload's `agent` field. Defaults to
# "claude" (Claude Code). Harnesses that reuse these hook scripts under a
# different CLI agent — e.g. plank (https://github.com/aovestdipaperino/plank),
# which speaks the same warp://cli-agent protocol — set WARP_CLI_AGENT_NAME
# to their own slug so Warp attributes sessions and notifications correctly.
build_payload() {
local input="$1"
local event="$2"
Expand All @@ -48,7 +53,7 @@ build_payload() {
# Extra args should be jq flag pairs like: --arg key "value" or --argjson key '{"a":1}'
jq -nc \
--argjson v "$protocol_version" \
--arg agent "claude" \
--arg agent "${WARP_CLI_AGENT_NAME:-claude}" \
--arg event "$event" \
--arg session_id "$session_id" \
--arg cwd "$cwd" \
Expand Down
7 changes: 7 additions & 0 deletions plugins/warp/tests/test-hooks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ echo "--- Common fields ---"
PAYLOAD=$(build_payload '{"session_id":"sess-123","cwd":"/Users/alice/my-project"}' "stop")
assert_json_field "v is 1" "$PAYLOAD" ".v" "1"
assert_json_field "agent is claude" "$PAYLOAD" ".agent" "claude"

echo ""
echo "--- Agent slug override ---"
PAYLOAD=$(WARP_CLI_AGENT_NAME=plank build_payload '{"session_id":"sess-123","cwd":"/Users/alice/my-project"}' "stop")
assert_json_field "agent honors WARP_CLI_AGENT_NAME" "$PAYLOAD" ".agent" "plank"
PAYLOAD=$(WARP_CLI_AGENT_NAME= build_payload '{"session_id":"sess-123","cwd":"/Users/alice/my-project"}' "stop")
assert_json_field "empty WARP_CLI_AGENT_NAME falls back to claude" "$PAYLOAD" ".agent" "claude"
assert_json_field "event is stop" "$PAYLOAD" ".event" "stop"
assert_json_field "session_id extracted" "$PAYLOAD" ".session_id" "sess-123"
assert_json_field "cwd extracted" "$PAYLOAD" ".cwd" "/Users/alice/my-project"
Expand Down