Add warp://tab_config/<name> deeplink by haha1903 · Pull Request #9379 · warpdotdev/warp

haha1903 · 2026-04-29T07:14:32Z

Closes #9060
Related to #9083

Description

Add a warp://tab_config/<name> URL scheme handler so users can launch a saved tab config straight from a deeplink (alongside the existing warp://launch/<name>).

By default the tab config opens as a new tab in the active window. Pass ?new_window=true (or invoke when no Warp window is open) to open in a brand-new window instead.

<name> is matched case-insensitively against the tab config's file stem, so both warp://tab_config/my_tab and warp://tab_config/my_tab.toml resolve to my_tab.toml. We key off the filename (not the name field inside the file) because multiple tab configs can share the same name.

The handler dispatches to the existing Workspace::open_tab_config, so the params modal and worktree branch generation flows are reused unchanged.

Gated on the existing FeatureFlag::TabConfigs.

Why

Lets users (and external tools / scripts / browser bookmarks) jump straight into a configured pane layout without going through the + menu. Mirrors the long-standing warp://launch/... deeplink for launch configs.

How

New UriHost::TabConfig variant in app/src/uri/mod.rs, parsed from tab_config host string and listed in validate_custom_uri's allowlist.
New handler handle_tab_config_uri that resolves the config and either reuses the active window's workspace or opens a new window (via open_new_window_get_handles), then calls workspace.open_tab_config(...).
Workspace::open_tab_config promoted from private to pub(crate) so it can be invoked from the URI handler.
Added a wasm-side stub for load_tab_configs so the cross-platform pub(crate) use imp::load_tab_configs; in user_config/mod.rs matches the pattern already used by load_launch_configs (no cfg gate needed).

Testing

Manual:

open "warposs://tab_config/<name>" opens the config as a new tab in the focused window.
open "warposs://tab_config/<name>?new_window=true" opens it in a new window.
Tab config with params triggers the existing params modal.
Worktree-style tab configs still get an autogenerated branch name.
Unknown <name> logs a warning and is a no-op.

cargo fmt and cargo clippy --workspace --all-targets --all-features --tests -- -D warnings both pass locally. Full ./script/presubmit will run on CI.

Server API dependencies

No server changes.

Agent Mode

Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Changelog Entries for Stable

CHANGELOG-IMPROVEMENT: Added a warp://tab_config/<name> deeplink that opens a saved tab config in the active window (or a new one with ?new_window=true).

Mirrors the existing warp://launch flow: resolves <name> against the user's tab configs (case-insensitive on the config name, falling back to the file stem) and dispatches to Workspace::open_tab_config, which already handles the params modal / worktree branch generation. By default the tab config opens as a new tab in the active window; pass ?new_window=true (or have no Warp window open) to open in a brand-new window instead. Gated on the existing FeatureFlag::TabConfigs.

cla-bot · 2026-04-29T07:14:36Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @haha1903 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

haha1903 · 2026-04-29T07:17:26Z

@cla-bot check

cla-bot · 2026-04-29T07:17:30Z

The cla-bot has been summoned, and re-checked this pull request!

oz-for-oss · 2026-04-29T12:15:57Z

@haha1903

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I requested changes on this pull request and posted feedback.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds a warp://tabconfig/<name> handler that resolves local tab configs by display name or source file stem and opens them in an existing or new workspace.

Concerns

The URI window-behavior hint can create a fallback window before the tabconfig handler sees ?new_window=true, which can violate the documented default/new-window behavior on platforms that cannot activate the existing window.
Security pass: no additional security findings beyond the window-selection behavior noted inline.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Use WindowBehaviorHint::Nothing so handle_tab_config_uri is the sole owner of the new-vs-reuse decision.

oz-for-oss · 2026-04-30T02:16:18Z

@haha1903

I'm checking this implementation PR for association with a likely matching ready issue.

Powered by Oz

haha1903 · 2026-05-03T02:55:45Z

/oz-review

oz-for-oss · 2026-05-03T02:55:56Z

@haha1903

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

haha1903 · 2026-05-03T02:59:14Z

Found matching issue #9060 (Support warp://tab_config/<tab_configuration_path>) — linked it via Closes #9060 in the PR body and left a comment there requesting ready-to-implement. #9083 covers the same ground from a broader angle and is referenced as Related to. Happy to adjust the URL path (tabconfig vs tab_config) or any other naming to match whatever the team prefers.

oz-for-oss

Overview

This PR adds a warp://tabconfig/<name> URI host, resolves saved tab configs by display name or file stem, and opens the selected config in an existing or new window.

Concerns

The new handler imports and calls root_view::workspace_for_window, but that helper is not present in the repository and is not added by this diff, so the PR will not compile.
This is user-visible behavior and the PR description does not include screenshots or a video demonstrating the deeplink flow end to end; per repository review guidance, please upload visual evidence for faster review.

Verdict

Found: 1 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

haha1903 · 2026-05-03T11:58:05Z

@seemeroland when you have a minute — could I get a look from you on this one? It mirrors the existing warp://launch/... flow for tab configs. Oz flagged a CRITICAL compile error on the workspace_for_window import, but that function is already pub fn at root_view.rs:550 (and cargo check -p warp --lib passes locally), so I pushed back in-thread. Thanks!

- Rename the URL host from tabconfig to tab_config to match issue #9060 - Match tab configs by file stem only; drop the TOML `name` field fallback since names are not unique across files - Drop the wasm-only #[expect(dead_code)] on tab_configs_dir since the URI handler now calls it on all targets

moirahuang

thanks for making the changes! just a few small comments now

- Import `TabConfig` at the top of `uri/mod.rs` instead of inline - Have `find_matching_tab_config` consume `Vec<TabConfig>` and return an owned `TabConfig`, dropping the clone at the callsite and the `'a` lifetime - Add a unit test covering stem matching with/without extension, case-insensitivity, misses, and configs missing `source_path`

# Conflicts: # app/src/uri/mod.rs

moirahuang · 2026-05-05T17:17:50Z

@haha1903 I just checked out the latest code locally and it's not compiling. Mind making sure it compiles + testing locally please?

The previous merge commit resolved the import hunk but left the three call sites referencing the removed `workspace_for_window` helper, breaking the build. Swap them for the `WorkspaceRegistry::as_ref(ctx) .get(window_id, ctx)` pattern used elsewhere.

haha1903 · 2026-05-06T01:47:30Z

@moirahuang apologies for the broken merge — that was my mistake. Root cause: during the master merge I staged the conflict resolution for the use hunk, then edited three more call sites (workspace_for_window → WorkspaceRegistry::as_ref(ctx).get(...), since workspace_for_window was removed in #9275) but forgot to git add them before committing the merge. The commit went out from a stale index.

Just pushed 92cdef3d with the missing swap. cargo check -p warp --lib and cargo test ... find_matching_tab_config both pass locally; waiting on CI to confirm.

# Conflicts: # app/src/uri/mod.rs

haha1903 · 2026-05-10T11:14:24Z

/oz-review

oz-for-oss · 2026-05-10T11:14:39Z

@haha1903

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds a warp://tab_config/<name> URI host, resolves saved tab configs by source file stem, and opens them through the existing tab-config workspace flow.

Concerns

Dotted tab-config file stems cannot be opened without the .toml suffix because the requested stem is always passed through remove_extension, which strips valid stem content after the final dot.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-10T11:20:57Z

+/// Case-insensitive match against each tab config's file stem. Tab config
+/// `name` fields are not unique across files, so we key off the filename.
+fn find_matching_tab_config(target: &str, configs: Vec<TabConfig>) -> Option<TabConfig> {
+    let stem = remove_extension(target).unwrap_or(target).to_lowercase();


⚠️ [IMPORTANT] This strips valid dotted stems, so a config saved as foo.bar.toml cannot be opened with warp://tab_config/foo.bar even though foo.bar is its file stem. Only strip the known .toml suffix, or try both the raw target and a .toml-stripped target.

Fixed in 2a2a1fbf — switched to the same two-step pattern find_matching_config uses (try the target as-is first, then with the extension stripped). foo.bar.toml now resolves via both warp://tab_config/foo.bar and warp://tab_config/foo.bar.toml; added a test case covering both.

`remove_extension` strips everything after the last `.`, so a config file named `foo.bar.toml` (stem `foo.bar`) could not be reached via `warp://tab_config/foo.bar` — the target got rewritten to `foo` before the lookup. Mirror `find_matching_config`'s pattern: try the target as-is first, then with the extension stripped. Covers both `foo.bar` and `foo.bar.toml` writing styles, and adds a test case.

haha1903 · 2026-05-10T11:30:36Z

/oz-review

oz-for-oss · 2026-05-10T11:30:50Z

@haha1903

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds a warp://tab_config/<name> custom URI host, resolves saved tab configs by filename stem, opens them in the active workspace or a new window, and exposes Workspace::open_tab_config for reuse by the URI handler.

Concerns

Manual testing is required for changes that can be manually tested. Please include screenshots or a screen recording that show the deeplink working end to end for the active-window and ?new_window=true flows, or justify why visual evidence is not possible.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

moirahuang · 2026-05-11T18:17:19Z

@haha1903 I just tried to test this locally and it wasn't opening a tab config. Mind recording and attaching you testing this locally please?

haha1903 · 2026-05-14T13:57:11Z

@haha1903 I just tried to test this locally and it wasn't opening a tab config. Mind recording and attaching you testing this locally please?

CleanShot.2026-05-14.at.23.52.13-converted.2.mp4

manually reviewed

haha1903 · 2026-05-15T01:38:19Z

Thanks @moirahuang for the review and merge! 🙏

Pins file-type defaults, Hammerspoon Wispr auto-submit, and the checked-in Brewfile to install and target Warp Preview alongside Stable. Preview ships weekly so newly-merged URI handlers (warpdotdev/warp#9379, the warp://tab_config/ scheme) light up in the daily driver within days of merge instead of weeks. Stable stays installed as the named fallback. URL schemes are channel-specific: warp:// owns Stable, warppreview:// owns Preview, so coily tooling that fires URIs picks the channel at call site. Preview auto-symlinks launch_configurations, tab_configs, and themes into ~/.warp/, so checked-in configs cover both channels for free. settings.toml is the one file that does not auto-share; the install playbook in warp/README.md symlinks Preview's settings.toml to the same source as Stable's so they stay in sync. set-warp-default-editor.sh now defaults to dev.warp.Warp-Preview and gates on WarpPreview.app, with WARP_DEFAULT_EDITOR_BUNDLE_ID and WARP_DEFAULT_EDITOR_APP_PATH env vars for per-host override (e.g. pinning kai-server or Windows to Stable). The Hammerspoon Wispr auto-submit accepts either Warp channel as frontmost so the flow works in both, not just whichever channel is the daily driver this month. closes #107

closes #108 Description string, config-location section, and SQLite/binary debug paths now cover both ~/.warp/ (Stable) and ~/.warp-preview/ (Preview, daily driver). Add a Channels table summarizing bundle ids, URL schemes, brew formulae, and Spotlight strings. Add a Launch configurations and tab configs section that names the warp:// and warppreview:// URI shapes plus the warpdotdev/warp#9379 provenance. Rename Host portability to Host and channel portability and call out the symlink-chain dependency hidden inside default_tab_config_path. Resolve the Cmd+I open question. Point See also at warp/README.md for the install playbook so the duti / lsregister / WARP_DEFAULT_EDITOR_BUNDLE_ID story is one click from the skill.

…override closes #273 Preview is the Mac daily driver per coilyco-flight-deck/agentic-os#107 and was the motivating consumer for the warpdotdev/warp#9379 tab_config URI handler. Stable is the named fallback when Preview wedges. The URL scheme picks the channel: warppreview:// always lands in Preview, warp:// always lands in Stable, with no LaunchServices toggle that flips this. Add a `--channel preview|stable` flag (default `preview`), introduce a `channelScheme` + `launchURL` pair that maps channel to scheme, and thread the resolved URL through the openWarpLaunch seam, dry-run output, and soft-fail fallback. Reject unknown channels at flag-parse time so the operator can't accidentally open Stable thinking they opened Preview. The launch-config name `claude-dispatch-interactive` resolves identically under either scheme because Preview auto-symlinks launch_configurations into ~/.warp/, so no agentic-os change is needed. Tests cover the channel -> scheme map, the unknown-channel rejection, and pin the new default-channel constant alongside the existing seam strings. Audit-log: coily://1779270571/AGPEJSSU - coily ops aws sts get-caller-identity Audit-log: coily://1779270571/AGPEJSSW - coily ops aws ssm get-parameter Audit-log: coily://1779271344/AGPEJVRB - coily ops gh issue view 270 Audit-log: coily://1779271371/AGPEJVUJ - coily ops gh run list Audit-log: coily://1779271378/AGPEJVVG - coily ops gh issue list Audit-log: coily://1779271395/AGPEJVXG - coily ops gh issue create Audit-log: coily://1779271486/AGPEJWCL - coily exec test

closes #115 warpdotdev/warp#9379 merged 2026-05-15. The previous 2026-05-13 Preview threshold was speculation from before the PR landed. Collapse to a single 2026-05-15 across both channels.

Warp's TabConfig schema (warpdotdev/warp#9379) defines commands as Vec<String>, not Vec<{exec: String}> like launch_config YAML. With deny_unknown_fields, the inline-table form failed toml deserialization silently — parse errors only surface via a UI toast that's suppressed on startup loads, so the failure was invisible in ~/Library/Logs/warp*.log and the URI handler logged "couldn't find a tab config matching X" even though the file existed on disk. closes #118 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Closes warpdotdev#9060 Related to warpdotdev#9083 ## Description Add a `warp://tab_config/<name>` URL scheme handler so users can launch a saved tab config straight from a deeplink (alongside the existing `warp://launch/<name>`). By default the tab config opens as a **new tab in the active window**. Pass `?new_window=true` (or invoke when no Warp window is open) to open in a brand-new window instead. `<name>` is matched case-insensitively against the tab config's file stem, so both `warp://tab_config/my_tab` and `warp://tab_config/my_tab.toml` resolve to `my_tab.toml`. We key off the filename (not the `name` field inside the file) because multiple tab configs can share the same `name`. The handler dispatches to the existing `Workspace::open_tab_config`, so the params modal and worktree branch generation flows are reused unchanged. Gated on the existing `FeatureFlag::TabConfigs`. ## Why Lets users (and external tools / scripts / browser bookmarks) jump straight into a configured pane layout without going through the `+` menu. Mirrors the long-standing `warp://launch/...` deeplink for launch configs. ## How - New `UriHost::TabConfig` variant in `app/src/uri/mod.rs`, parsed from `tab_config` host string and listed in `validate_custom_uri`'s allowlist. - New handler `handle_tab_config_uri` that resolves the config and either reuses the active window's workspace or opens a new window (via `open_new_window_get_handles`), then calls `workspace.open_tab_config(...)`. - `Workspace::open_tab_config` promoted from private to `pub(crate)` so it can be invoked from the URI handler. - Added a wasm-side stub for `load_tab_configs` so the cross-platform `pub(crate) use imp::load_tab_configs;` in `user_config/mod.rs` matches the pattern already used by `load_launch_configs` (no `cfg` gate needed). ## Testing Manual: - `open "warposs://tab_config/<name>"` opens the config as a new tab in the focused window. - `open "warposs://tab_config/<name>?new_window=true"` opens it in a new window. - Tab config with `params` triggers the existing params modal. - Worktree-style tab configs still get an autogenerated branch name. - Unknown `<name>` logs a warning and is a no-op. `cargo fmt` and `cargo clippy --workspace --all-targets --all-features --tests -- -D warnings` both pass locally. Full `./script/presubmit` will run on CI. ## Server API dependencies No server changes. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode ## Changelog Entries for Stable CHANGELOG-IMPROVEMENT: Added a `warp://tab_config/<name>` deeplink that opens a saved tab config in the active window (or a new one with `?new_window=true`).

cla-bot Bot added the cla-signed label Apr 29, 2026

haha1903 marked this pull request as ready for review April 29, 2026 12:15

oz-for-oss Bot requested changes Apr 29, 2026

View reviewed changes

Comment thread app/src/uri/mod.rs Outdated

Avoid duplicate empty window on Linux/Wayland for warp://tabconfig

9cf4182

Use WindowBehaviorHint::Nothing so handle_tab_config_uri is the sole owner of the new-vs-reuse decision.

captainsafia added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Apr 30, 2026 — with Warp Dev Github Integration

haha1903 mentioned this pull request May 3, 2026

Support warp://tab_config/<tab_configuration_path> #9060

Closed

2 tasks

oz-for-oss Bot requested changes May 3, 2026

View reviewed changes

Comment thread app/src/uri/mod.rs Outdated

moirahuang reviewed May 3, 2026

View reviewed changes

Comment thread app/src/uri/mod.rs Outdated

Comment thread app/src/uri/mod.rs Outdated

haha1903 changed the title ~~Add warp://tabconfig/<name> deeplink~~ Add warp://tab_config/<name> deeplink May 4, 2026

moirahuang reviewed May 5, 2026

View reviewed changes

Comment thread app/src/uri/mod.rs Outdated

Comment thread app/src/uri/mod.rs

haha1903 added 2 commits May 5, 2026 11:03

Merge remote-tracking branch 'origin/master' into haichang/tabconfig-uri

3eac248

# Conflicts: # app/src/uri/mod.rs

Merge remote-tracking branch 'origin/master' into haichang/tabconfig-uri

a9b3b15

# Conflicts: # app/src/uri/mod.rs

oz-for-oss Bot requested changes May 10, 2026

View reviewed changes

oz-for-oss Bot previously requested changes May 10, 2026

View reviewed changes

moirahuang approved these changes May 15, 2026

View reviewed changes

moirahuang enabled auto-merge (squash) May 15, 2026 00:55

moirahuang merged commit 207f9d5 into warpdotdev:master May 15, 2026
26 checks passed

haha1903 deleted the haichang/tabconfig-uri branch May 15, 2026 01:36

coilysiren mentioned this pull request May 20, 2026

Run Warp Preview as default with Stable as fallback for the Mac daily driver coilyco-flight-deck/agentic-os#107

Closed

coilysiren mentioned this pull request May 20, 2026

Refresh tooling-warp SKILL.md for Preview channel split coilyco-flight-deck/agentic-os#108

Closed

This was referenced May 20, 2026

Warp Preview silently drops warppreview://tab_config URIs coilyco-flight-deck/agentic-os#116

Closed

tab_configs claude-dispatch-interactive.toml uses wrong commands schema, inline tables vs bare strings coilyco-flight-deck/agentic-os#118

Closed

coilysiren mentioned this pull request May 20, 2026

dispatch shim: read FIFO queue and echo title before claude coilyco-flight-deck/agentic-os#121

Closed

hongyi-chen mentioned this pull request May 21, 2026

Document warp://tab_config/<name> deeplink warpdotdev/docs#123

Merged

moirahuang mentioned this pull request Jun 16, 2026

Support opening Tab Configs from CLI with parameters #12343

Open

Uh oh!

Conversation

haha1903 commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Why

How

Testing

Server API dependencies

Agent Mode

Changelog Entries for Stable

Uh oh!

cla-bot Bot commented Apr 29, 2026

Uh oh!

haha1903 commented Apr 29, 2026

Uh oh!

cla-bot Bot commented Apr 29, 2026

Uh oh!

oz-for-oss Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

oz-for-oss Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haha1903 commented May 3, 2026

Uh oh!

oz-for-oss Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haha1903 commented May 3, 2026

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

haha1903 commented May 3, 2026

Uh oh!

Uh oh!

Uh oh!

moirahuang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

moirahuang commented May 5, 2026

Uh oh!

haha1903 commented May 6, 2026

Uh oh!

haha1903 commented May 10, 2026

Uh oh!

oz-for-oss Bot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 10, 2026

Choose a reason for hiding this comment

Uh oh!

haha1903 May 10, 2026

Choose a reason for hiding this comment

Uh oh!

haha1903 commented May 10, 2026

Uh oh!

oz-for-oss Bot commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haha1903 commented Apr 29, 2026 •

edited

Loading

oz-for-oss Bot commented Apr 29, 2026 •

edited

Loading

oz-for-oss Bot commented Apr 30, 2026 •

edited

Loading

oz-for-oss Bot commented May 3, 2026 •

edited

Loading

oz-for-oss Bot commented May 10, 2026 •

edited

Loading

oz-for-oss Bot commented May 10, 2026 •

edited

Loading