Skip to content

fix(themes): Handle tilde in theme paths#9634

Open
rrroyal wants to merge 3 commits intowarpdotdev:masterfrom
rrroyal:fix/custom-theme-path-tilde
Open

fix(themes): Handle tilde in theme paths#9634
rrroyal wants to merge 3 commits intowarpdotdev:masterfrom
rrroyal:fix/custom-theme-path-tilde

Conversation

@rrroyal
Copy link
Copy Markdown

@rrroyal rrroyal commented Apr 30, 2026

Description

When using settings sync between machines with different usernames, custom theme gets reset every time the settings sync. All settings reference mention ~/.warp/themes/my-theme.yaml, so figured it should support it. It didn't, so I (with some help from Copilot) have added it.

Linked Issue

Mainly targeted at my own use case, but probably also #6678.

Screenshots / Videos

Screenshot 2026-04-30 at 19 21 19

Testing

Verified in real-world with ./script/run/cargo run using paths with and without ~.
Tested only on macOS - I don't have access to a Windows or Linux machine as of right now.

Also added tests for themes (theme_test.rs) and warp_core (theme_tests.rs). If they seem redundant, please let me know and I'll remove one of them.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode
  • Copilot-assisted - This PR was created using Copilot assistance.

CHANGELOG-IMPROVEMENT: Added support for tilde (~) in custom theme paths.

@cla-bot cla-bot Bot added the cla-signed label Apr 30, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Apr 30, 2026

@rrroyal

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @vorporeal.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds tilde expansion and contraction for custom theme paths, including the settings-file path that uses SettingsValue and serde-based paths used for sync/serialization.

Concerns

  • None.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from vorporeal April 30, 2026 17:35
@captainsafia captainsafia added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Apr 30, 2026 — with Warp Dev Github Integration
@vorporeal vorporeal requested review from a team, kevinchevalier and vorporeal and removed request for a team and vorporeal April 30, 2026 18:23
@kevinchevalier
Copy link
Copy Markdown
Contributor

Thank you for the submission! This works really well.

Can you run cargo fmt to fix the formatting errors and then I will merge it in.

@rrroyal
Copy link
Copy Markdown
Author

rrroyal commented Apr 30, 2026

Thank you for the submission! This works really well.

Can you run cargo fmt to fix the formatting errors and then I will merge it in.

done @kevinchevalier :)

thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants