AWS Setup: uploaded yaml and code files#45
AWS Setup: uploaded yaml and code files#45kabathla wants to merge 2 commits intowavefrontHQ:masterfrom
Conversation
kabathla
changed the title
|
@yogeshprasad, can you please review. |
yogeshprasad
left a comment
yogeshprasad
left a comment
There was a problem hiding this comment.
Please scan the Python file using pylint, flake8 and pydocstring.
|
for flake8, there are no scanning issues: for pylint, we have the following scan outcomes:
for pydocstring, there is a scan comment to add the description of the function which I have added already.
|
yogeshprasad
left a comment
yogeshprasad
left a comment
There was a problem hiding this comment.
Minor comment otherwise LGTM
| role_arn, prefix, bucket_name) | ||
| if bucket_name != "": | ||
| api_url = hostname+"/api/v2/cloudintegration" | ||
| requests.post(api_url, |
There was a problem hiding this comment.
Can we please confirm the status here
2 participants
As part of https://wavefront.atlassian.net/browse/INT-1037, I have uploaded yaml files which are used to create the cloudformation template and the lambda code (to create the AWS Setup) written in Python is also uploaded.