Skip to content

fix wbolster#45#46

Merged
wbolster merged 1 commit into
wbolster:masterfrom
bricewge:fix-45
Jun 7, 2019
Merged

fix wbolster#45#46
wbolster merged 1 commit into
wbolster:masterfrom
bricewge:fix-45

Conversation

@bricewge
Copy link
Copy Markdown
Contributor

@bricewge bricewge commented Jun 1, 2019

file-directory-p try to initiate a connection so I moved the file-remote-p before it.

@wbolster
Copy link
Copy Markdown
Owner

wbolster commented Jun 7, 2019

wow, nice debugging since this is non obvious 👍

while at it, any chance you can move the string-equals-p up (right after the non-nil check) so that this cheap check runs before the (potentially slower) file path checks?

@bricewge
Copy link
Copy Markdown
Contributor Author

bricewge commented Jun 7, 2019

Is it better now?

@wbolster
Copy link
Copy Markdown
Owner

wbolster commented Jun 7, 2019

thanks!

@wbolster wbolster merged commit 5633ba2 into wbolster:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants