Treat direnv-non-file-modes as possibly derived modes.#49
Merged
Conversation
Say major-mode is magit-status-mode, which is derived from magit-mode. With this change, if direnv-non-file-modes contains magit-mode, direnv-mode will still treat it as a non-file mode.
wbolster
approved these changes
Jun 19, 2019
Owner
wbolster
left a comment
wbolster
left a comment
There was a problem hiding this comment.
in general, looks good. minor question above
Owner
|
thanks! whenever this is merged, another pr that adds magit to the defaults sounds fine |
I'h having a hard time believing it but I had indent-tabs-mode t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppose we're in a Magit Status buffer, whose
major-modeismagit-status-mode, which is derived frommagit-mode.With this change, if
direnv-non-file-modescontainsmagit-mode,direnv-modewill now treat it as a non-file mode.
Open question: do we add
magit-modeto the default list?