Skip to content

feat: make using nonce extension configurable during OCSP requests#10

Merged
mrts merged 1 commit into
mainfrom
issue-9-Make_using_nonce_during_OCSP_requests_configurable
Feb 25, 2021
Merged

feat: make using nonce extension configurable during OCSP requests#10
mrts merged 1 commit into
mainfrom
issue-9-Make_using_nonce_during_OCSP_requests_configurable

Conversation

@mrts
Copy link
Copy Markdown
Member

@mrts mrts commented Feb 23, 2021

Resolves #9

@mrts mrts added this to the v1.0.1 milestone Feb 23, 2021
@mrts mrts requested a review from metsma February 23, 2021 17:50
Signed-off-by: Mart Somermaa <mrts@users.noreply.github.com>
@mrts mrts force-pushed the issue-9-Make_using_nonce_during_OCSP_requests_configurable branch from c23e5c0 to e3c7717 Compare February 23, 2021 21:37
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@metsma metsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use policy?

@mrts
Copy link
Copy Markdown
Member Author

mrts commented Feb 25, 2021

Maybe use policy?

It is a good idea, but we decided to stick to URLs during our discussion. Main benefit of URLs is that they correspond one to one to the particular OCSP service, unlike policies. It is theoretically possible that different cards with different policies use the same OCSP URL, so URLs have a slight edge over policies.

@mrts mrts requested a review from metsma February 25, 2021 12:24
@mrts mrts merged commit 1a78169 into main Feb 25, 2021
@mrts mrts deleted the issue-9-Make_using_nonce_during_OCSP_requests_configurable branch February 25, 2021 13:14
svenzik pushed a commit that referenced this pull request May 6, 2025
…d mention .NET versions (#10)

Signed-off-by: Mart Somermaa <mrts@users.noreply.github.com>

Co-authored-by: Mart Somermaa <mrts@users.noreply.github.com>
svenzik pushed a commit that referenced this pull request May 21, 2025
…d mention .NET versions (#10)

Signed-off-by: Mart Somermaa <mrts@users.noreply.github.com>

Co-authored-by: Mart Somermaa <mrts@users.noreply.github.com>
mrts added a commit that referenced this pull request May 26, 2025
…d mention .NET versions (#10)

Signed-off-by: Mart Somermaa <mrts@users.noreply.github.com>

Co-authored-by: Mart Somermaa <mrts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make using nonce during OCSP requests configurable

2 participants