Skip to content

Test that setting innerText on <br> etc doesn't throw #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcorpan merged 2 commits into from
Jan 10, 2017
Merged

Test that setting innerText on <br> etc doesn't throw #3491

zcorpan merged 2 commits into from
Jan 10, 2017

Conversation

@zcorpan
Copy link
Member

@zcorpan zcorpan commented Aug 18, 2016

This was referenced Aug 18, 2016
Open
Merged
@ayg ayg closed this Aug 28, 2016
@ayg ayg deleted the innertext-setter-nothrow branch August 28, 2016 13:58
@zcorpan
Copy link
Member Author

zcorpan commented Aug 28, 2016

Why did you close this and my other innerText PRs @ayg??

@zcorpan zcorpan restored the innertext-setter-nothrow branch August 28, 2016 20:10
@zcorpan zcorpan reopened this Aug 28, 2016
@ayg ayg closed this Oct 26, 2016
@ayg ayg deleted the innertext-setter-nothrow branch October 26, 2016 17:38
@ayg ayg restored the innertext-setter-nothrow branch October 26, 2016 17:41
@ayg ayg reopened this Oct 26, 2016
@wpt-stability-bot
Copy link

wpt-stability-bot commented Oct 26, 2016

Chrome

Testing revision 161322f
Starting 10 test iterations
All results were stable

All results

/innerText/setter.html

elementelement
Subtest Results
OK
Newlines convert to
in 
 element
 PASS
innerText on
FAIL
Simplest possible test PASS
innerText on element FAIL
> preserved PASS
innerText on
FAIL
innerText on element FAIL
innerText on element FAIL
Tabs preserved PASS
< preserved PASS
' preserved PASS
Existing
deleted		 PASS
Newlines convert to
in white-space:pre element		 PASS
Null characters preserved PASS
innerText on element element element elementelement
FAIL
innerText on element PASS
innerText not supported on MathML elements PASS
innerText on
element		 FAIL
Newline/CR pair converts to
in non-white-space:pre element		 PASS
innerText not supported on SVG elements PASS
innerText on element FAIL
innerText on element FAIL
innerText on
FAIL
innerText on
FAIL
& preserved PASS
CRs convert to
in 
 element
 PASS
innerText on element FAIL
innerText on
element		 FAIL
Assigning the empty string PASS
Whitespace not compressed PASS
innerText on
FAIL
Existing text deleted PASS
CRs convert to
in white-space:pre element		 PASS
Trailing whitespace preserved PASS
innerText on element FAIL
innerText on element FAIL
Assigning undefined PASS
innerText on element FAIL
innerText on element FAIL
innerText on element FAIL
innerText on element FAIL
CR/CR pair converts to two
s in non-white-space:pre element		 PASS
innerText on element FAIL
Newline/newline pair converts to two
s in non-white-space:pre element		 PASS
innerText on element FAIL
Newlines convert to
in non-white-space:pre elements		 PASS
innerText on element FAIL
CRs convert to
in non-white-space:pre elements		 PASS
Leading whitespace preserved PASS
innerText on element FAIL
innerText on element FAIL
innerText on
FAIL
Assigning null PASS
innerText on element FAIL
" preserved PASS

@wpt-stability-bot
Copy link

wpt-stability-bot commented Oct 26, 2016

Firefox

Testing revision 161322f
Starting 10 test iterations
All results were stable

All results

/innerText/setter.html

elementelement
Subtest Results
OK
Newlines convert to
in 
 element
 PASS
innerText on
PASS
Simplest possible test PASS
innerText on element PASS
> preserved PASS
innerText on
PASS
innerText on element PASS
innerText on element PASS
Tabs preserved PASS
< preserved PASS
' preserved PASS
Existing
deleted		 PASS
Newlines convert to
in white-space:pre element		 PASS
Null characters preserved PASS
innerText on element element element elementelement
PASS
innerText on element PASS
innerText not supported on MathML elements PASS
innerText on
element		 PASS
Newline/CR pair converts to
in non-white-space:pre element		 PASS
innerText not supported on SVG elements PASS
innerText on element PASS
innerText on element PASS
innerText on
PASS
innerText on
PASS
& preserved PASS
CRs convert to
in 
 element
 PASS
innerText on element PASS
innerText on
element		 PASS
Assigning the empty string PASS
Whitespace not compressed PASS
innerText on
PASS
Existing text deleted PASS
CRs convert to
in white-space:pre element		 PASS
Trailing whitespace preserved PASS
innerText on element PASS
innerText on element PASS
Assigning undefined PASS
innerText on element PASS
innerText on element PASS
innerText on element PASS
innerText on element PASS
CR/CR pair converts to two
s in non-white-space:pre element		 PASS
innerText on element PASS
Newline/newline pair converts to two
s in non-white-space:pre element		 PASS
innerText on element PASS
Newlines convert to
in non-white-space:pre elements		 PASS
innerText on element PASS
CRs convert to
in non-white-space:pre elements		 PASS
Leading whitespace preserved PASS
innerText on element PASS
innerText on element PASS
innerText on
PASS
Assigning null PASS
innerText on element PASS
" preserved PASS

@zcorpan zcorpan mentioned this pull request Dec 30, 2016
Closed
domenic added a commit that referenced this pull request Jan 10, 2017
@domenic
Remove innerText tests; they are covered by #3491
887852f
@domenic domenic mentioned this pull request Jan 10, 2017
Merged
domenic added a commit that referenced this pull request Jan 10, 2017
@domenic
Remove innerText tests; they are covered by #3491
a381691
@wpt-stability-bot
Copy link

wpt-stability-bot commented Jan 10, 2017

Firefox

Testing revision c8181b9
Starting 10 test iterations
All results were stable

All results

/innerText/setter.html
Subtest Results
OK
Newlines convert to <br> in <pre> element PASS
innerText on <tbody> element PASS
Simplest possible test PASS
innerText on <meta> element PASS
> preserved PASS
innerText on <col> element PASS
innerText on <head> element PASS
innerText on <area> element PASS
Tabs preserved PASS
< preserved PASS
' preserved PASS
Existing <br> deleted PASS
Newlines convert to <br> in white-space:pre element PASS
Null characters preserved PASS
innerText on <table> element PASS
innerText on <menuitem> element PASS
innerText not supported on MathML elements PASS
innerText on <br> element PASS
Newline/CR pair converts to <br> in non-white-space:pre element PASS
innerText not supported on SVG elements PASS
innerText on <basefont> element PASS
innerText on <source> element PASS
innerText on <tr> element PASS
innerText on <thead> element PASS
& preserved PASS
CRs convert to <br> in <pre> element PASS
innerText on <frame> element PASS
innerText on <hr> element PASS
Assigning the empty string PASS
Whitespace not compressed PASS
innerText on <tfoot> element PASS
Existing text deleted PASS
CRs convert to <br> in white-space:pre element PASS
Trailing whitespace preserved PASS
innerText on <input> element PASS
innerText on <base> element PASS
Assigning undefined PASS
innerText on <frameset> element PASS
innerText on <wbr> element PASS
innerText on <param> element PASS
innerText on <keygen> element PASS
CR/CR pair converts to two <br>s in non-white-space:pre element PASS
innerText on <track> element PASS
Newline/newline pair converts to two <br>s in non-white-space:pre element PASS
innerText on <link> element PASS
Newlines convert to <br> in non-white-space:pre elements PASS
innerText on <image> element PASS
CRs convert to <br> in non-white-space:pre elements PASS
Leading whitespace preserved PASS
innerText on <embed> element PASS
innerText on <html> element PASS
innerText on <colgroup> element PASS
Assigning null PASS
innerText on <img> element PASS
innerText on <bgsound> element PASS
" preserved PASS

@wpt-stability-bot
Copy link

wpt-stability-bot commented Jan 10, 2017

Chrome

Testing revision c8181b9
Starting 10 test iterations
All results were stable

All results

/innerText/setter.html
Subtest Results
OK
Newlines convert to <br> in <pre> element PASS
innerText on <tbody> element FAIL
Simplest possible test PASS
innerText on <meta> element FAIL
> preserved PASS
innerText on <col> element FAIL
innerText on <head> element FAIL
innerText on <area> element FAIL
Tabs preserved PASS
< preserved PASS
' preserved PASS
Existing <br> deleted PASS
Newlines convert to <br> in white-space:pre element PASS
Null characters preserved PASS
innerText on <table> element FAIL
innerText on <menuitem> element PASS
innerText not supported on MathML elements PASS
innerText on <br> element FAIL
Newline/CR pair converts to <br> in non-white-space:pre element PASS
innerText not supported on SVG elements PASS
innerText on <basefont> element FAIL
innerText on <source> element FAIL
innerText on <tr> element FAIL
innerText on <thead> element FAIL
& preserved PASS
CRs convert to <br> in <pre> element PASS
innerText on <frame> element FAIL
innerText on <hr> element FAIL
Assigning the empty string PASS
Whitespace not compressed PASS
innerText on <tfoot> element FAIL
Existing text deleted PASS
CRs convert to <br> in white-space:pre element PASS
Trailing whitespace preserved PASS
innerText on <input> element FAIL
innerText on <base> element FAIL
Assigning undefined PASS
innerText on <frameset> element FAIL
innerText on <wbr> element FAIL
innerText on <param> element FAIL
innerText on <keygen> element FAIL
CR/CR pair converts to two <br>s in non-white-space:pre element PASS
innerText on <track> element FAIL
Newline/newline pair converts to two <br>s in non-white-space:pre element PASS
innerText on <link> element FAIL
Newlines convert to <br> in non-white-space:pre elements PASS
innerText on <image> element FAIL
CRs convert to <br> in non-white-space:pre elements PASS
Leading whitespace preserved PASS
innerText on <embed> element FAIL
innerText on <html> element FAIL
innerText on <colgroup> element FAIL
Assigning null PASS
innerText on <img> element FAIL
innerText on <bgsound> element PASS
" preserved PASS

@zcorpan zcorpan merged commit 4451bd8 into master Jan 10, 2017
@zcorpan zcorpan deleted the innertext-setter-nothrow branch January 10, 2017 21:58
domenic added a commit that referenced this pull request Jan 10, 2017
@domenic
Test that createContextualFragment works on a variety of contexts
b3163fb 
As discovered and discussed in whatwg/html#2221 (comment) , some browsers have a blocklist here that seems historical and not supported by any spec.

The same blocklist is shared by innerText (tested in #3491) and outerText (not tested as it's not yet standard).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

Assignees

No one assigned

Labels

innerText status:needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zcorpan @wpt-stability-bot @domenic @sideshowbarker @ayg @wpt-pr-bot