This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Add more wallet signing tests#3163
Merged
Conversation
cgewecke
commented
Oct 27, 2019
nivida
approved these changes
Oct 30, 2019
Contributor
nivida
left a comment
nivida
left a comment
There was a problem hiding this comment.
LGTM - Just added some code style comments
Co-Authored-By: Samuel Furter <nivida@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for:
(Trying to improve the coverage a bit with these, but also found a small bug - see below)
[EDIT 27/10 - The coveralls-github hook looks broken atm, these jobs are getting processed there but there's no feedback]