Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Referencing of the contribution guidelines#3296

Merged
nivida merged 2 commits into1.xfrom
documentation/referencing-of-contributions-guidelines
Jan 7, 2020
Merged

Referencing of the contribution guidelines#3296
nivida merged 2 commits into1.xfrom
documentation/referencing-of-contributions-guidelines

Conversation

@nivida
Copy link
Contributor

@nivida nivida commented Jan 7, 2020

Description

Added a reference to the guidelines in the PULL_REQUEST_TEMPLATE and the root README.

Type of change

  • Documentation

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added Documentation Relates to project wiki or documentation 1.x 1.0 related issues labels Jan 7, 2020
@nivida nivida merged commit 7918661 into 1.x Jan 7, 2020
@nivida nivida deleted the documentation/referencing-of-contributions-guidelines branch January 9, 2020 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Documentation Relates to project wiki or documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant