Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

add berlin tx support - #4083

Closed
GregTheGreek wants to merge 6 commits into
1.xfrom
greg/berlin
Closed

add berlin tx support#4083
GregTheGreek wants to merge 6 commits into
1.xfrom
greg/berlin

Conversation

@GregTheGreek

@GregTheGreek GregTheGreek commented May 25, 2021

Copy link
Copy Markdown
Contributor

Description

Adds berlin tx support.

Notes about tests:
Since the new transaction type changes how the transactions are RLP'd some of the messages hashes needed to be updated. Only test cases with error: false (or omitted completely) will run successfully in the first place, and thus tests with error: true did not need to be updated.

closes #3963
closes #4012 (supersedes)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render

render Bot commented May 25, 2021

Copy link
Copy Markdown

@lgtm-com

lgtm-com Bot commented May 25, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging d965f2e into 1ed3c68 - view on LGTM.com

new alerts:

  • 1 for Self assignment

@lgtm-com

lgtm-com Bot commented May 25, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 27f53e8 into 1ed3c68 - view on LGTM.com

new alerts:

  • 1 for Self assignment

@lgtm-com

lgtm-com Bot commented May 25, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging b1446c3 into 1ed3c68 - view on LGTM.com

new alerts:

  • 1 for Self assignment

@lgtm-com

lgtm-com Bot commented May 25, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging c61dd9c into 1ed3c68 - view on LGTM.com

new alerts:

  • 1 for Self assignment

@coveralls

coveralls commented May 25, 2021

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 893882309

  • 2 of 13 (15.38%) changed or added relevant lines in 1 file are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 73.714%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/web3-eth-accounts/src/index.js 2 13 15.38%
Files with Coverage Reduction New Missed Lines %
packages/web3-eth-accounts/lib/index.js 23 85.27%
Totals Coverage Status
Change from base Build 864210061: -0.02%
Covered Lines: 3282
Relevant Lines: 4215

💛 - Coveralls

@lgtm-com

lgtm-com Bot commented May 25, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging bdedfa4 into 1ed3c68 - view on LGTM.com

new alerts:

  • 1 for Self assignment

@GregTheGreek
GregTheGreek marked this pull request as ready for review May 26, 2021 04:04
@lgtm-com

lgtm-com Bot commented May 26, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 8954009 into 1ed3c68 - view on LGTM.com

new alerts:

  • 1 for Self assignment

luu-alex
luu-alex previously approved these changes May 27, 2021

@Spacesai1or Spacesai1or left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dist/ files were updated, but should only be updated upon release, otherwise, it looks good!

Comment thread test/eth.accounts.signTransaction.js Outdated
Comment thread test/eth.accounts.signTransaction.js Outdated
@GregTheGreek
GregTheGreek dismissed stale reviews from ghost and luu-alex via a049e06 May 31, 2021 19:42
@lgtm-com

lgtm-com Bot commented May 31, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert when merging b005b0a into 1ed3c68 - view on LGTM.com

new alerts:

  • 1 for Self assignment

@GregTheGreek

GregTheGreek commented Jun 9, 2021

Copy link
Copy Markdown
Contributor Author

Currently blocked by ethereumjs/ethereumjs-monorepo#1292 but local testing shows it solves our problems 🎊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Berlin hard-fork

4 participants