Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Bump maxPriorityFeePerGas to 2.5 Gwei - Closes #4283 - #4284

Merged
nazarhussain merged 6 commits into
1.xfrom
nh/4283-max-priority-fee
Sep 2, 2021
Merged

Bump maxPriorityFeePerGas to 2.5 Gwei - Closes #4283#4284
nazarhussain merged 6 commits into
1.xfrom
nh/4283-max-priority-fee

Conversation

@nazarhussain

@nazarhussain nazarhussain commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

Description

Update the occurrence of default value of maxPriorityFeePerGas from 0x3B9ACA00 to 0x9502F900. Which is equivalent of 1 Gwei to 2.5 Gwei.

Fixes #4283

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have updated the CHANGELOG.md file in the root folder.

@render

render Bot commented Aug 31, 2021

Copy link
Copy Markdown

@nazarhussain
nazarhussain force-pushed the nh/4283-max-priority-fee branch from c4d6d96 to d1d629f Compare August 31, 2021 16:03
@nazarhussain
nazarhussain marked this pull request as ready for review August 31, 2021 19:37
Comment thread test/eth.accounts.signTransaction.js
Comment thread test/eth.accounts.signTransaction.js
Comment thread test/e2e.method.signing.js
@coveralls

coveralls commented Sep 1, 2021

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1194019196

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 249 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.6%) to 75.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/web3-eth-accounts/src/index.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 6 84.39%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/utils.js 31 8.46%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-eth-accounts/src/index.js 105 26.2%
Totals Coverage Status
Change from base Build 1146629454: 2.6%
Covered Lines: 3195
Relevant Lines: 4008

💛 - Coveralls

Spacesai1or
Spacesai1or previously approved these changes Sep 1, 2021
@Spacesai1or

Copy link
Copy Markdown
Contributor

Awesome job!

luu-alex
luu-alex previously approved these changes Sep 1, 2021
@nazarhussain
nazarhussain dismissed stale reviews from luu-alex and Spacesai1or via 94c168e September 2, 2021 11:41
@nazarhussain
nazarhussain force-pushed the nh/4283-max-priority-fee branch from 4a95490 to 94c168e Compare September 2, 2021 11:41
@nazarhussain
nazarhussain force-pushed the nh/4283-max-priority-fee branch from 94c168e to 7862582 Compare September 2, 2021 11:42
@nazarhussain nazarhussain self-assigned this Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump maxPriorityFeePerGas to 2.5 Gwei

4 participants