This repository was archived by the owner on Mar 5, 2025. It is now read-only.
add tx.chainId if tx.common.chainId not provided - #4293
Merged
Conversation
|
Your Render PR Server URL is https://web3-js-pr-4293.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4r37ssobjddd9dbhe50. |
Pull Request Test Coverage Report for Build 1261469566
💛 - Coveralls |
jdevcs
marked this pull request as ready for review
September 7, 2021 10:22
Spacesai1or
reviewed
Sep 8, 2021
Spacesai1or
reviewed
Sep 8, 2021
Spacesai1or
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a formatting suggestion
nazarhussain
suggested changes
Sep 9, 2021
luu-alex
previously approved these changes
Sep 16, 2021
Spacesai1or
previously approved these changes
Sep 16, 2021
nazarhussain
approved these changes
Sep 22, 2021
luu-alex
approved these changes
Sep 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#4208
Throw error if user provided
tx.chainIdandtx.common.customChain.chainIdplus these are not matching.Not considering
tx.chainIdiftx.common.customChain.chainIdis provided forweb3.eth.accounts.signTransactionfunction ,Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.