This repository was archived by the owner on Mar 5, 2025. It is now read-only.
add: custom transaction polling interval - #4584
Merged
Spacesai1or merged 8 commits intoJan 7, 2022
Merged
Conversation
allow to set via options the interval which polls for TX status
nazarhussain
suggested changes
Dec 2, 2021
nazarhussain
left a comment
nazarhussain
left a comment
Contributor
There was a problem hiding this comment.
Hi @sirpy Thanks for contribution. Please add relevant docs under docs/ folder to reflect the changes.
Also update the CHANGELOG.md to specify what new config been added.
Contributor
|
@sirpy Did you get a chance to look into feedback I posted earlier. I will encourage you to complete it so we can include this PR in upcoming sprint. |
nazarhussain
added
Changes Requested
Pull Request Test Coverage Report for Build 1569176448
💛 - Coveralls |
Author
|
@nazarhussain updated |
nazarhussain
approved these changes
Dec 15, 2021
jdevcs
suggested changes
Dec 17, 2021
jdevcs
left a comment
jdevcs
left a comment
Contributor
There was a problem hiding this comment.
Build / e2e_windows (pull_request) is failing on this PR, needs to be fixed
also could you add test for passing custom transactionPollingInterval
Author
|
@jdevcs I dont see how this PR is related to this error. In anycase I wouldnt have any idea how to fix it. |
Spacesai1or
changed the base branch from
1.x
to
wyatt/1.x/4584-windows-test-debug
January 7, 2022 02:28
Contributor
Author
|
@spacesailor24 thanks |
Spacesai1or
added a commit
that referenced
this pull request
Jan 14, 2022
* add: custom transaction polling interval (#4584) * add: custom transaction polling interval allow to set via options the interval which polls for TX status * add: transactionPollingInterval to contract * add: pass transactionPollingInterval to method * Update CHANGELOG.md * add: transactionPollingInterval docs Co-authored-by: Nazar Hussain <nazarhussain@gmail.com> * Add transactionPollingInterval to web3-eth * Init transactionPollingInterval tests * Update docs/web3-eth.rst Co-authored-by: jdevcs <86780488+jdevcs@users.noreply.github.com> * Update docs/web3-eth-contract.rst Co-authored-by: jdevcs <86780488+jdevcs@users.noreply.github.com> * Move 4672 change to 1.7.1 Co-authored-by: sirpy <hadarr@gmail.com> Co-authored-by: Nazar Hussain <nazarhussain@gmail.com> Co-authored-by: jdevcs <86780488+jdevcs@users.noreply.github.com>
Merged
This was referenced Feb 11, 2022
This was referenced Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
allow to set via options the interval which polls for TX status
#2621
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.