Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix static tuple encoding - #4673

Merged
jdevcs merged 4 commits into
web3:junaid/fixstatictupleencoding4673from
biswajitpatra:fix-static-tuple-encoding
Mar 23, 2022
Merged

Fix static tuple encoding#4673
jdevcs merged 4 commits into
web3:junaid/fixstatictupleencoding4673from
biswajitpatra:fix-static-tuple-encoding

Conversation

@biswajitpatra

@biswajitpatra biswajitpatra commented Jan 7, 2022 •
edited
Loading

Copy link
Copy Markdown

Description

Fixes #4610

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@github-actions

github-actions Bot commented Mar 10, 2022

Copy link
Copy Markdown

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions Bot added the Stale Has not received enough activity label Mar 10, 2022
@jdevcs jdevcs added 1.x 1.0 related issues Review Needed Maintainer(s) need to review and removed Stale Has not received enough activity labels Mar 16, 2022
@coveralls

coveralls commented Mar 16, 2022 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2005854326

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 443 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.217%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-eth-abi/lib/index.js 14 90.19%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 2002669572: -2.3%
Covered Lines: 3372
Relevant Lines: 4401
💛 - Coveralls

@jdevcs
jdevcs self-requested a review March 23, 2022 12:42
@jdevcs
jdevcs changed the base branch from 1.x to junaid/fixstatictupleencoding4673 March 23, 2022 12:46
@jdevcs
jdevcs merged commit f44284d into web3:junaid/fixstatictupleencoding4673 Mar 23, 2022
@jdevcs jdevcs mentioned this pull request Mar 23, 2022
Merged
16 tasks
jdevcs added a commit that referenced this pull request Apr 12, 2022
@jdevcs @biswajitpatra @Spacesai1or
Fix static tuple encoding (#4673) (#4884)
5a437ce 
* Fix static tuple encoding (#4673)

* updated change log

* Trigger build

* Trigger build 2

* Update CHANGELOG.md

Co-authored-by: Biswajit <patrabiswajit133@gmail.com>
Co-authored-by: Wyatt Barnes <me@wyatt.email>
@jdevcs jdevcs mentioned this pull request May 17, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@luu-alex luu-alex Awaiting requested review from luu-alex
@nikoulai nikoulai Awaiting requested review from nikoulai
@Spacesai1or Spacesai1or Awaiting requested review from Spacesai1or
3 more reviewers
@nazarhussain nazarhussain nazarhussain approved these changes
@avkos avkos avkos approved these changes
@jdevcs jdevcs jdevcs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.x 1.0 related issues Review Needed Maintainer(s) need to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support of tuple[2] type

5 participants

@biswajitpatra @coveralls @nazarhussain @avkos @jdevcs