Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

adding effective gas price to transactionreceipt - #4694

Merged
luu-alex merged 8 commits into
1.xfrom
4692/transaction-receipt-effective-gas-price
Jan 12, 2022
Merged

adding effective gas price to transactionreceipt#4694
luu-alex merged 8 commits into
1.xfrom
4692/transaction-receipt-effective-gas-price

Conversation

@luu-alex

@luu-alex luu-alex commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

Description

#4692
Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render

render Bot commented Jan 12, 2022

Copy link
Copy Markdown

Comment thread packages/web3-core/types/index.d.ts
@Spacesai1or

Copy link
Copy Markdown
Contributor

I think you could add a test here

@Spacesai1or

Copy link
Copy Markdown
Contributor

I think the only other thing this needs is for the docs to be updated (including the return value in the example)

@luu-alex
luu-alex marked this pull request as ready for review January 12, 2022 01:28
@luu-alex
luu-alex requested a review from Spacesai1or January 12, 2022 01:28
Comment thread docs/web3-eth.rst Outdated

@Spacesai1or Spacesai1or left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one more suggestion - Awesome job 🚀

@nazarhussain

Copy link
Copy Markdown
Contributor

@luu-alex Please create a relevant issue for the 4.x as well.

@jdevcs

jdevcs commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

Good work @luu-alex , changes LGTM,
Last thing could you check failing Build / unit (14) (pull_request) before merging

@luu-alex

luu-alex commented Jan 12, 2022

Copy link
Copy Markdown
Contributor Author

@luu-alex Please create a relevant issue for the 4.x as well.

#4693 👍 @nazarhussain

@mark-b-ab

Copy link
Copy Markdown

effective gas price and other price values should be a big number.

Starting web3.js 1.7.1 you will be unable to get a receipt for the transaction

Reason - very big gas price, number overflow

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants