Fix Build Command (supersedes #4848)

[Spacesai1or]

Original PR: #4848, this fixed some merge conflicts with package-lock.json

Something to note is a ran npm i which apparently fixed the version number of all packages, changing them from 1.7.1-rc.0 to 1.7.1

[render]

Your Render PR Server URL is https://web3-js-pr-4861.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8pe78nd17cafaqrv75g.

[coveralls]

Pull Request Test Coverage Report for Build 2002666498

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 265 unchanged lines in 7 files lost coverage.
• Overall coverage increased (+2.3%) to 74.497%

---

Files with Coverage Reduction	New Missed Lines	%
packages/web3-core-requestmanager/src/jsonrpc.js	1	70.0%
packages/web3-core-helpers/src/formatters.js	7	85.42%
packages/web3-core-helpers/src/errors.js	29	1.56%
packages/web3-utils/src/soliditySha3.js	34	3.43%
packages/web3-utils/src/index.js	43	31.38%
packages/web3-utils/src/utils.js	44	9.66%
packages/web3-eth-accounts/src/index.js	107	23.67%

Totals
Change from base Build 1999712194:	2.3%
Covered Lines:	3238
Relevant Lines:	4102

---

💛 - Coveralls

[jdevcs]

We should not make changes in package-lock.json in this PR, as scope of issue is for improvement in build commands

[wbt]

@jdevcs this PR introduces a new dependency on rimraf for the rm -rf functionality, so package-lock.json does need to be on the changed files list.

[jdevcs]

Suggested change

	"rimraf": "^3.0.2",

[jdevcs]

Suggested change

	"cov:clean": "rimraf .nyc_output && rimraf coverage",
	"cov:clean": "rm -rf .nyc_output; rm -rf coverage",

[wbt]

The suggested change actively reduces cross-platform compatibility. Can you explain why it's important to avoid any changes to package-lock?

[jdevcs]

@wbt We include changes in package-lock files via dedicated and internally initialized PRs only.

[wbt]

This is now formally an internally initialized PR. Going out of your way to reduce cross-platform compatibility and break the command on some platforms just doesn't seem like the right direction.

[jdevcs]

@wbt We include changes in package-lock files via dedicated and internally initialized PRs only.

Internal and also dedicated PRs for package lock changes. Thanks

[wbt]

However, the version of this PR which does not change all the package-lock files this one does was rejected at #4848. In theory, I believe that one could be reopened and merged, but @spacesailor24 seems to prefer the version with all the additional package-lock changes while @jdevcs strongly disagrees, and meanwhile the command nominally required to be run for every PR remains broken.

[jdevcs]

@wbt , we discussed this internally that @spacesailor24 will re generate package lock files in this PR, but there are errors when he tried. #4861 (comment)

Our team is occupied in 4.x so could you investigate and share it.

[wbt]

@jdevcs can you just reopen #4848?

[jdevcs]

Its already merged so couldn't reopen.

[wbt]

Replaced with #4939.

[jdevcs]

@jdevcs this PR introduces a new dependency on rimraf for the rm -rf functionality, so package-lock.json does need to be on the changed files list.

@spacesailor24 we need to remove changes from package lock files in this PR. thanks

[avkos]

rimraf works exactly the same as rm-rf but with cross-platform support. Why do we need to change rimraf to rm -rf? What is it solve?

[Spacesai1or]

rimraf works exactly the same as rm-rf but with cross-platform support. Why do we need to change rimraf to rm -rf? What is it solve?

@avkos Web3.js supports Windows, OSX, and Linux environments, hence the cross platform support needed for removing files

[Spacesai1or]

Okay so I deleted all the package-lock.json files and regenerated them with npm i, and now when running npm run build we're getting the errors:

../../node_modules/@ethereumjs/common/dist/types.d.ts(38,32): error TS1005: ',' expected.
../../node_modules/@ethereumjs/common/dist/types.d.ts(38,58): error TS1005: ',' expected.
../../node_modules/@ethereumjs/common/dist/types.d.ts(40,12): error TS1005: ',' expected.
../../node_modules/@ethereumjs/common/dist/types.d.ts(41,9): error TS1005: ',' expected.
../../node_modules/@ethereumjs/common/dist/types.d.ts(42,12): error TS1005: ',' expected.

[avkos]

rimraf works exactly the same as rm-rf but with cross-platform support. Why do we need to change rimraf to rm -rf? What is it solve?

@avkos Web3.js supports Windows, OSX, and Linux environments, hence the cross platform support needed for removing files

I mean rimraf is better than rm -rf. We need to use it